Rename obj.supressButtonReaction to obj.suppressButtonReaction
#547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`obj.supressButtonReaction` will still work for the time being, so this can be merged ASAP without breaking code. A warning will be listed once in the log. Please remove this concession ASAP.
MasterBel2
added a commit
to MasterBel2/BYAR-Chobby
that referenced
this pull request
Jun 26, 2022
- Decrease button & font sizes to give ready / start buttons more prominence - Use i18n lib for tooltips - Change tooltip depending on button state - Add `SetButtonStatePlaying()` and `SetButtonStateSpectating()` to avoid duplication of constants throughout the code. - Tooltip/caption values set after button init with `SetButtonStatePlaying()` - Move `button_highlight` style colours to mirror `option_button` colours - Makes use of `suppressButtonReaction` to remove hints that the play/spectating buttons are pressable when they aren't (This won't work until Spring-Chobby/Chobby#547 is merged, due to a typo in the source.)
Beherith
pushed a commit
to beyond-all-reason/BYAR-Chobby
that referenced
this pull request
Jul 1, 2022
* Ready button default to unready; dec font size for ready & start buttons - Fixes "Not Ready" outsizing ready button on default scaling on 1080p displays - Fixes ready button being grey with "Button" caption by default * Update Play / Spectating button styling - Decrease button & font sizes to give ready / start buttons more prominence - Use i18n lib for tooltips - Change tooltip depending on button state - Add `SetButtonStatePlaying()` and `SetButtonStateSpectating()` to avoid duplication of constants throughout the code. - Tooltip/caption values set after button init with `SetButtonStatePlaying()` - Move `button_highlight` style colours to mirror `option_button` colours - Makes use of `suppressButtonReaction` to remove hints that the play/spectating buttons are pressable when they aren't (This won't work until Spring-Chobby/Chobby#547 is merged, due to a typo in the source.)
Contributor
|
Does this one still need a merge? I dunno of other games on chobby base wont suffer from this |
FIr3baL
added a commit
to FIr3baL/BYAR-Chobby
that referenced
this pull request
Apr 30, 2023
leaned on original PR from MasterBel2 for Spring-Chobby Spring-Chobby/Chobby#547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obj.supressButtonReactionwill still work for the time being, so this can be merged ASAP without breaking code. A warning will be listed once in the log.Please remove this concession ASAP.