Add escape for a pipe ("|") character in table cells #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary
Added escape of pipe ("|") character in table cells. Fixes - Spenhouet#108
## Changes Made
### 1. Core Implementation
- **File**: `confluence_markdown_exporter/utils/table_converter.py`
- Added escaping of `|` char in `convert_th` and `convert_td` methods
### 2. Test Coverage
- **File**: `tests/unit/test_table_converter.py` (new file)
- Created test suite with several cases to test pipe character escaping in table cells
## Testing
All tests pass successfully:
- 4 pipe char escaping specific tests
- 78 total unit tests (including existing tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added escape of pipe ("|") character in table cells. Fixes - #108
Changes Made
1. Core Implementation
confluence_markdown_exporter/utils/table_converter.py|char inconvert_thandconvert_tdmethods2. Test Coverage
tests/unit/test_table_converter.py(new file)Testing
All tests pass successfully: