Clippy warning fixes #112
Merged
Clippy warning fixes #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiegeLord
requested changes
Dec 14, 2025
Owner
SiegeLord
left a comment
SiegeLord
left a comment
There was a problem hiding this comment.
Thanks! This looks mostly like a positive change, but I would prefer one of the diffs reverted. I don't recall if that's a specific clippy setting for it, maybe clippy::redundant_field_names, but feel free to allow it in lib.rs
| .as_ref() | ||
| .and_then(|d| d.path().to_str()) | ||
| .map(|s| s.into()), | ||
| data_tempdir: data_tempdir, |
Contributor
Author
There was a problem hiding this comment.
Should be reverted now, added #([allow(...)] for the remaining clippy lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to most warnings reported by
cargo clippyAlso fixes warnings from cargo test
tempfile::TempDir::into_path: use TempDir::keep()Remaining two issues are about function having too many parameters and are not as easily fixed.