Skip to content

Conversation

@ericlee878
Copy link
Contributor

@ericlee878 ericlee878 commented Dec 10, 2025

Resolves: https://github.com/orgs/shop/projects/208/views/34?pane=issue&itemId=143907836&issue=shop%7Cissues-api-foundations%7C1160

WHY are these changes introduced?

Improve the user experience when polling for bulk operations by showing a task indicator.

WHAT is this pull request doing?

  • Enhances shortBulkOperationPoll to display a task indicator while checking the bulk operation status
  • Update unit tests correspondingly

How to test your changes?

  1. Run a command that uses bulk operations
  2. Verify that a "Checking bulk operation status..." indicator appears in the console
  3. Confirm that the operation completes successfully with the indicator show

Screenshot 2025-12-09 at 4.53.52 PM.png

ing progress

Copy link
Contributor Author

ericlee878 commented Dec 10, 2025

@ericlee878 ericlee878 marked this pull request as ready for review December 10, 2025 00:54
@ericlee878 ericlee878 requested a review from a team as a code owner December 10, 2025 00:54
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.5% (+0.28% 🔼)
14168/17822
🟡 Branches
73.56% (+0.34% 🔼)
6954/9453
🟡 Functions
79.65% (+0.3% 🔼)
3635/4564
🟡 Lines
79.87% (+0.29% 🔼)
13394/16770
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / metafield_definitions.ts
100% 100% 100% 100%
🟢
... / metaobject_definitions.ts
100% 100% 100% 100%
🟢
... / declarative-definitions.ts
98.54% 93.18% 100% 98.51%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / execute-operation.ts
92.86%
80% (-3.33% 🔻)
100% 92.31%
🟢
... / execute-bulk-operation.ts
92.75%
87.23% (-0.52% 🔻)
100% 93.94%
🟢
... / watch-bulk-operation.ts
100%
94.74% (-5.26% 🔻)
100% 100%
🟢
... / developer-platform-client.ts
84.62%
71.43% (-2.26% 🔻)
81.82%
93.75% (+3.13% 🔼)
🔴
... / environment.ts
35% (-6.67% 🔻)
41.18% (-1.68% 🔻)
40% (-10% 🔻)
36.84% (-6.64% 🔻)

Test suite run success

3544 tests passing in 1414 suites.

Report generated by 🧪jest coverage report action from a17b645

@ericlee878 ericlee878 force-pushed the 12-09-user-display-during-short-poll branch from 43bda24 to c79a291 Compare December 10, 2025 19:51
@ericlee878 ericlee878 force-pushed the 12-04-cli-quick-watch-feature branch from fb8280d to c59e0b5 Compare December 10, 2025 19:51
@ericlee878 ericlee878 force-pushed the 12-09-user-display-during-short-poll branch from c79a291 to d5a3f88 Compare December 10, 2025 20:00
@ericlee878 ericlee878 force-pushed the 12-04-cli-quick-watch-feature branch from c59e0b5 to 65302ac Compare December 10, 2025 20:00
Copy link
Contributor

@jordanverasamy jordanverasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good~

@ericlee878 ericlee878 force-pushed the 12-04-cli-quick-watch-feature branch from 65302ac to 4b4ce44 Compare December 11, 2025 19:19
@ericlee878 ericlee878 force-pushed the 12-09-user-display-during-short-poll branch from d5a3f88 to 46c4d3b Compare December 11, 2025 19:19
@ericlee878 ericlee878 force-pushed the 12-04-cli-quick-watch-feature branch from 4b4ce44 to 910f6b0 Compare December 12, 2025 18:30
@ericlee878 ericlee878 force-pushed the 12-09-user-display-during-short-poll branch from 46c4d3b to a17b645 Compare December 12, 2025 18:30
Base automatically changed from 12-04-cli-quick-watch-feature to main December 12, 2025 18:54
@ericlee878 ericlee878 added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit a170b5a Dec 12, 2025
25 of 45 checks passed
@ericlee878 ericlee878 deleted the 12-09-user-display-during-short-poll branch December 12, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants