[py] Remove noqa markers and fix linting

[cgoldberg]

User description

💥 What does this PR do?

This PR removes #noqa markers and fixes all linting violations in py/selenium/webdriver/common/bidi/cdp.py that we were previously skipping.

No functional changes.

🔄 Types of changes

• Cleanup (formatting, renaming)
• Linting

---

PR Type

Enhancement

---

Description

• Remove # flake8: noqa marker and fix all linting violations

• Consolidate imports and reorganize import statements

• Reformat docstrings to comply with linting standards

• Add missing blank line in Firefox options file

---

Diagram Walkthrough

flowchart LR
  A["cdp.py with noqa markers"] -- "Remove flake8 noqa" --> B["Clean imports"]
  B -- "Consolidate imports" --> C["Reorganized imports"]
  C -- "Reformat docstrings" --> D["Compliant docstrings"]
  D -- "Fix line spacing" --> E["Lint-free code"]

Loading

File Walkthrough

Relevant files

Cleanup

cdp.py Linting fixes and import consolidation in CDP module          py/selenium/webdriver/common/bidi/cdp.py Removed # flake8: noqa marker from file header Consolidated imports: combined contextlib imports and moved collections.abc imports to single line Reorganized import order to follow PEP 8 standards Reformatted multi-line docstrings to single-line format where appropriate Enhanced docstring formatting for methods like listen(), _handle_cmd_response(), _reader_task(), and open_cdp() Removed unnecessary blank lines and fixed spacing issues +31/-44  options.py Minor formatting and linting fixes                                              py/selenium/webdriver/firefox/options.py Added blank line after license header for PEP 8 compliance Removed # noqa comment from @binary_location.setter decorator +2/-1

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: No new logging: The PR only adjusts imports and docstrings without adding or modifying any critical action logging, so audit trail coverage cannot be assessed from the diff alone. Referred Code logger.debug(f"Received CDP message: {response}") if isinstance(response, Exception): if logger.isEnabledFor(logging.DEBUG): logger.debug(f"Exception raised by {cmd_event} message: {type(response).__name__}") raise response return response def listen(self, *event_types, buffer_size=10): """Listen for events. Returns: An async iterator that iterates over events matching the indicated types. """ sender, receiver = trio.open_memory_channel(buffer_size) for event_type in event_types: self.channels[event_type].add(sender) return receiver Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: No error changes: The changes are limited to docstrings and imports without introducing or altering error handling paths, so robustness against failures and edge cases cannot be determined from the new lines. Referred Code """Handle a response to a command. This will set an event flag that will return control to the task that called the command. Args: data: response as a JSON dictionary """ cmd_id = data["id"] Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Potential verbose logs: Existing debug logging of full CDP messages appears unchanged but remains potentially sensitive; this PR does not add new logs, yet secure logging compliance cannot be confirmed without full context. Referred Code logger.debug(f"Received CDP message: {response}") if isinstance(response, Exception): if logger.isEnabledFor(logging.DEBUG): logger.debug(f"Exception raised by {cmd_event} message: {type(response).__name__}") raise response return response Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: No validation changes: The PR only adjusts a decorator and formatting without changing input validation or data handling, so security posture cannot be evaluated from the new code alone. Referred Code def binary_location(self) -> str: """Returns the location of the binary.""" return self._binary_location @binary_location.setter def binary_location(self, value: str) -> None: """Sets the location of the browser binary by string.""" if not isinstance(value, str): raise TypeError(self.BINARY_LOCATION_ERROR) Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.