Skip to content

Conversation

@domsolutions
Copy link
Contributor

@domsolutions domsolutions commented Nov 7, 2025

Why

When customers have issues dpeloying new releases, from looking at their logs, it's hard to tell if we're looking at the previous version or newly deployed version. This PR injects the release tag at compile time for binaries:

  • controller
  • scheduler
  • model gw
  • pipeline gw
  • agent
  • dataflow engine

It will print the version to the logs when the pod spins up. Additionally added -version as an arg, which will print the version and exit.

Summary of changes

  • updated makefiles to inject release tag
  • updated dockerfiles to set release tag
  • updated gh worfklow to set release tag (untested as will push to docker repo)
  • ideally we would set the git tag within the binaries of the images, but this wasn't possible as we create many tags when making a release i.e. scheduler/v2.10.0 operator/v2.10.0 which all point to the same commit, it won't make any sense to have the operator to print version scheduler/v2.10.0 for example. Instead we just set the tag provided by the releaser with ${{ github.event.inputs.docker-tag }}. We should look at if we really need all these different tags and can simplify it.

Checklist

  • Added/updated unit tests
  • Added/updated documentation
  • Checked for typos in variable names, comments, etc.
  • Added licences for new files

Testing

@domsolutions domsolutions requested a review from lc525 as a code owner November 7, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants