-
Notifications
You must be signed in to change notification settings - Fork 0
Task/add metrics monitoring #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ozgen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don’t see the issue expectations fully met here. You’ve added changes in the application.yml, but the task also requires defining custom metrics inside the Spring Boot application. At the moment, I don’t see any new code in src related to custom metrics. Could you add the required implementation? @SelahattinSert
Is this what you mean? @ozgen |
So this includes the custom metrics you set up within the application, correct? @SelahattinSert I could not see any changes on your java code thats why I asked. |
|
I added them just now, I haven't pushed them yet, I asked to verify that I did it correctly. @ozgen |
Can I skip Sonatype OSS Index Analyzer while during dependency check because I am out of free credit and I should provide an api key if I want to use Sonatype OSS Index Analyzer. But if you want I can create an account. What do you think should I do? @ozgen |
yeap you can skip this for now @SelahattinSert |
ozgen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to say, the way you implemented the metrics turned out even better than I expected. @SelahattinSert
No new topics from me at the moment. If you want to pick up something, just create an issue and go for it. Congrats on finishing your onboarding and thanks for all the effort you put in @SelahattinSert
src/main/java/com/onboarding/camera/cameraonboarding/service/impl/LightSensorService.java
Outdated
Show resolved
Hide resolved
|
Thank you so much @ozgen 🙏 |



No description provided.