Skip to content

Conversation

@SelahattinSert
Copy link
Owner

No description provided.

@SelahattinSert SelahattinSert self-assigned this Sep 19, 2025
Copy link
Collaborator

@ozgen ozgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don’t see the issue expectations fully met here. You’ve added changes in the application.yml, but the task also requires defining custom metrics inside the Spring Boot application. At the moment, I don’t see any new code in src related to custom metrics. Could you add the required implementation? @SelahattinSert

@SelahattinSert
Copy link
Owner Author

image

Is this what you mean? @ozgen

@ozgen
Copy link
Collaborator

ozgen commented Sep 23, 2025

image Is this what you mean? @ozgen

So this includes the custom metrics you set up within the application, correct? @SelahattinSert

I could not see any changes on your java code thats why I asked.

@SelahattinSert
Copy link
Owner Author

I added them just now, I haven't pushed them yet, I asked to verify that I did it correctly. @ozgen

@SelahattinSert
Copy link
Owner Author

Ekran görüntüsü 2025-09-24 124545

Can I skip Sonatype OSS Index Analyzer while during dependency check because I am out of free credit and I should provide an api key if I want to use Sonatype OSS Index Analyzer. But if you want I can create an account. What do you think should I do? @ozgen

@ozgen
Copy link
Collaborator

ozgen commented Sep 24, 2025

Ekran görüntüsü 2025-09-24 124545

Can I skip Sonatype OSS Index Analyzer while during dependency check because I am out of free credit and I should provide an api key if I want to use Sonatype OSS Index Analyzer. But if you want I can create an account. What do you think should I do? @ozgen

yeap you can skip this for now @SelahattinSert

Copy link
Collaborator

@ozgen ozgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say, the way you implemented the metrics turned out even better than I expected. @SelahattinSert

No new topics from me at the moment. If you want to pick up something, just create an issue and go for it. Congrats on finishing your onboarding and thanks for all the effort you put in @SelahattinSert

@SelahattinSert
Copy link
Owner Author

Thank you so much @ozgen 🙏
Your feedback truly made me very happy. I am also really grateful for all the guidance and support you have given me through this process. Thanks for making the onboarding such a valuable and enjoyable experience. I am looking forward to contributing to new topics soon.

@SelahattinSert SelahattinSert merged commit 779476a into main Sep 28, 2025
3 checks passed
@SelahattinSert SelahattinSert deleted the task/add-metrics-monitoring branch September 28, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants