Add CI for push docker image #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
ozgen
requested changes
Feb 23, 2025
Collaborator
ozgen
left a comment
ozgen
left a comment
There was a problem hiding this comment.
i added few comments @SelahattinSert
azure-pipelines.yml
Outdated
Comment on lines
13
to
16
| imageRepository: 'cameraonboarding' | ||
| containerRegistry: 'acrcameraonboarding.azurecr.io' | ||
| dockerfilePath: '$(Build.SourcesDirectory)/Dockerfile' | ||
| buildVersion: $[format('{0:yyyyMMdd}-{1}', pipeline.startTime, variables['Build.SourceVersion'])] |
Collaborator
There was a problem hiding this comment.
these are also variable, why don't you use variables like secrets
ozgen
approved these changes
Feb 25, 2025
Collaborator
ozgen
left a comment
ozgen
left a comment
There was a problem hiding this comment.
I approved the changes for testing purposes @SelahattinSert please check the this pipeline works properly, if yes, please let me know, then i will create an other issue for you
Owner
Author
|
Based on the screenshots, it should to be work correctly. Do you notice any issues? @ozgen |
Collaborator
|
no it seems functioning properly @SelahattinSert you can close this issue, i will create another one for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.