Create ci.yml

[SelahattinSert]

Create a ci pipeline for master branch

[ozgen]

test comment

[ozgen]

you did not add the branch policy for the comments @SelahattinSert

[ozgen]

I could not see the settings tab in your repository. please add the rule that `Pull requests cannot be merged if there are unresolved comments.`

[ozgen]

The system should also prevent merging if the pull request has not been approved. @SelahattinSert

[SelahattinSert]

Can i merge? @ozgen

[ozgen]

please add branch policy for the comments too @SelahattinSert

[ozgen]

Can i merge? @ozgen

ofcourse not, did you check the acceptance criteria? @SelahattinSert

[SelahattinSert]

firstly i tried to add ruleset but then i couldn't see anything for required checks then i thought the ci.yaml file should be added for the required checks @ozgen

[ozgen]

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges

can you read these? @SelahattinSert

[SelahattinSert]

I guess i did it. If anything is wrong please inform me @ozgen

[ozgen]

the ci yml is enough but you still need to fix: https://graphite.dev/guides/prevent-merge-without-review-github

@SelahattinSert

https://github.com/orgs/community/discussions/55218

https://blog.balthazar-rouberol.com/preventing-a-pull-request-from-being-merged-until-its-safe

[SelahattinSert]

Should i move my work into an organization, because i already added other branch protection rules beforehand.
Can you see them @ozgen

[ozgen]

Should i move my work into an organization, because i already added other branch protection rules beforehand.

Can you see them @ozgen

ohh i see now, you can merge this PR and close the issue @SelahattinSert