Skip to content

fix Non-Numeric-u0 #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

fix Non-Numeric-u0 #737

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11735a0
fix Non-Numeric-u0
oscardssmith Nov 17, 2025
687b55a
typo
oscardssmith Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lib/NonlinearSolveBase/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,8 @@ function solve_call(_prob, args...; merge_callbacks = true, kwargshandle = nothi
throw(NonConcreteEltypeError(RecursiveArrayTools.recursive_unitless_eltype(_prob.u0)))
end

if !(eltype(_prob.u0) <: Number) && !(eltype(_prob.u0) <: Enum) &&
!(_prob.u0 isa AbstractVector{<:AbstractArray} && _prob isa BVProblem)
# Allow Enums for FunctionMaps, make into a trait in the future
# BVPs use Vector of Arrays for initial guesses
throw(NonNumberEltypeError(eltype(_prob.u0)))
if !(eltype(_prob.u0) <: Number) && !(eltype(_prob.u0) <: Enum)
throw(SciMLBase.NonNumberEltypeError(eltype(_prob.u0)))
end
end

Expand Down
7 changes: 7 additions & 0 deletions test/core_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,3 +444,10 @@ end
sol = solve(prob)
@test SciMLBase.successful_retcode(sol)
end

@testitem "NonNumberEltype error" tags=[:core] begin
u0_broken = [rand(2), rand(2)]
f(u,p) = u
prob = NonlinearProblem(f, u0_broken)
@test_throws SciMLBase.NonNumberEltypeError solve(prob)=
end
Loading