Skip to content

Turn off DI strictness #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2025
Merged

Turn off DI strictness #643

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb9bd0d
Turn off DI strictness
ChrisRackauckas Jul 19, 2025
256efe8
Update jacobian.jl
ChrisRackauckas Jul 19, 2025
cc0286f
Update SciMLJacobianOperators.jl
ChrisRackauckas Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/SimpleNonlinearSolve/src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ end
function prepare_jacobian(prob, autodiff, fx, x)
SciMLBase.has_jac(prob.f) && return AnalyticJacobian()
if SciMLBase.isinplace(prob.f)
return DIExtras(DI.prepare_jacobian(prob.f, fx, autodiff, x, Constant(prob.p)))
return DIExtras(DI.prepare_jacobian(prob.f, fx, autodiff, x, Constant(prob.p), strict = Val(false)))
Copy link
Contributor

@github-actions github-actions bot Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
return DIExtras(DI.prepare_jacobian(prob.f, fx, autodiff, x, Constant(prob.p), strict = Val(false)))
return DIExtras(DI.prepare_jacobian(
prob.f, fx, autodiff, x, Constant(prob.p), strict = Val(false)))

else
x isa SArray && return DINoPreparation()
return DIExtras(DI.prepare_jacobian(prob.f, autodiff, x, Constant(prob.p)))
return DIExtras(DI.prepare_jacobian(prob.f, autodiff, x, Constant(prob.p), strict = Val(false)))
Copy link
Contributor

@github-actions github-actions bot Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
return DIExtras(DI.prepare_jacobian(prob.f, autodiff, x, Constant(prob.p), strict = Val(false)))
return DIExtras(DI.prepare_jacobian(
prob.f, autodiff, x, Constant(prob.p), strict = Val(false)))

end
end

Expand Down
Loading