Skip to content

Continue on with the polyalg if a stalledsuccess #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Continue on with the polyalg if a stalledsuccess #622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95ef3dc
Continue on with the polyalg if a stalledsuccess
ChrisRackauckas May 21, 2025
0917284
Update lib/NonlinearSolveBase/src/solve.jl
ChrisRackauckas May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/NonlinearSolveBase/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ end
$(prob_syms[i]), alg.algs[$(i)], args...;
stats, alias_u0, verbose, kwargs...
)
if SciMLBase.successful_retcode($(cur_sol))
if SciMLBase.successful_retcode($(cur_sol)) && $(cur_sol).retcode !== ReturnCode.StalledSuccess
Copy link
Contributor

@github-actions github-actions bot May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
if SciMLBase.successful_retcode($(cur_sol)) && $(cur_sol).retcode !== ReturnCode.StalledSuccess
if SciMLBase.successful_retcode($(cur_sol)) &&
$(cur_sol).retcode !== ReturnCode.StalledSuccess

if alias_u0
copyto!(u0, $(cur_sol).u)
$(u_result_syms[i]) = u0
Expand Down
Loading