Skip to content

Fix incorrect stalledsuccess #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix incorrect stalledsuccess #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/NonlinearSolveBase/src/termination_conditions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,8 @@ function (cache::NonlinearTerminationModeCache)(
min_obj, max_obj = extrema(cache.objectives_trace)
end
if min_obj < mode.min_max_factor * max_obj
if cache.leastsq
# If least squares, found a local minima thus success
cache.retcode = ReturnCode.StalledSuccess
else
# Not a success if f(x)>0 and residual too high
cache.retcode = ReturnCode.Stalled
end
# Not a success if f(x)>0 and residual too high
cache.retcode = ReturnCode.Stalled
return true
end
end
Expand Down
Loading