Skip to content

mark BVP tests as broken for now #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

mark BVP tests as broken for now #3600

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31ba025
mark tests as broken for now
vyudu May 5, 2025
dd22c66
remove show
vyudu May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions test/optimal_control.jl → test/bvproblem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
### TODO: update when BoundaryValueDiffEqAscher is updated to use the normal boundary condition conventions
using OrdinaryDiffEq
using BoundaryValueDiffEqMIRK, BoundaryValueDiffEqAscher
using BenchmarkTools
using ModelingToolkit
using SciMLBase
using ModelingToolkit: t_nounits as t, D_nounits as D
Expand Down Expand Up @@ -30,8 +29,8 @@ daesolvers = [Ascher2, Ascher4, Ascher6]

for solver in solvers
sol = solve(bvp, solver(), dt = 0.01)
@test isapprox(sol.u[end], osol.u[end]; atol = 0.01)
@test sol.u[1] == [1.0, 2.0]
@test_broken isapprox(sol.u[end], osol.u[end]; atol = 0.01)
@test_broken sol.u[1] == [1.0, 2.0]
end

# Test out of place
Expand All @@ -40,8 +39,8 @@ daesolvers = [Ascher2, Ascher4, Ascher6]

for solver in solvers
sol = solve(bvp2, solver(), dt = 0.01)
@test isapprox(sol.u[end], osol.u[end]; atol = 0.01)
@test sol.u[1] == [1.0, 2.0]
@test_broken isapprox(sol.u[end], osol.u[end]; atol = 0.01)
@test_broken sol.u[1] == [1.0, 2.0]
end
end

Expand Down Expand Up @@ -125,18 +124,18 @@ end
bvpi4 = SciMLBase.BVProblem{false, SciMLBase.FullSpecialize}(
lksys, [x(t) => 1.0], tspan; guesses = [y(t) => 1.0])

sol1 = @btime solve($bvpi1, MIRK4(), dt = 0.01)
sol2 = @btime solve($bvpi2, MIRK4(), dt = 0.01)
sol3 = @btime solve($bvpi3, MIRK4(), dt = 0.01)
sol4 = @btime solve($bvpi4, MIRK4(), dt = 0.01)
sol1 = solve(bvpi1, MIRK4(), dt = 0.01)
sol2 = solve(bvpi2, MIRK4(), dt = 0.01)
sol3 = solve(bvpi3, MIRK4(), dt = 0.01)
sol4 = solve(bvpi4, MIRK4(), dt = 0.01)
@test sol1 ≈ sol2 ≈ sol3 ≈ sol4 # don't get true equality here, not sure why
end

function test_solvers(
solvers, prob, u0map, constraints, equations = []; dt = 0.05, atol = 1e-2)
for solver in solvers
println("Solver: $solver")
sol = @btime solve($prob, $solver(), dt = $dt, abstol = $atol)
sol = solve(prob, solver(), dt = dt, abstol = atol)
@test SciMLBase.successful_retcode(sol.retcode)
p = prob.p
t = sol.t
Expand Down
Loading