-
-
Notifications
You must be signed in to change notification settings - Fork 236
add toplevel arguments to various getters #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChrisRackauckas
merged 12 commits into
SciML:master
from
TorkelE:add_toplevel_getter_kwarg
Mar 18, 2025
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
186a7d3
add toplevel arguments
TorkelE 1d872e0
update with aayush code to handle flattened systems
TorkelE 0641937
add tests
TorkelE 7867202
formatting
TorkelE 3e07adf
create separate _toplevel function versions isntead
TorkelE 04d8dda
update for new tests
TorkelE 9e459e2
formating
TorkelE e151999
add docs
TorkelE be8d20d
format fixes
TorkelE 56ec622
Update src/systems/abstractsystem.jl
TorkelE 4536f98
Update docs/src/basics/AbstractSystem.md
TorkelE 9a19c1d
broken tests no longer broken
TorkelE File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a leftover from the code being copied from the
observedgetter (?), in which case it would make sense to usecbsand notobsthroughout the function.