Skip to content

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Dec 11, 2025

Description

This PR does:

  • Updates the flash barycenter to use only coated PMTs, as it has been shown to improve the performance both in data and mc.
  • Introduces new threshold for barycenter algorithm (optimised independently for each TPC) both in data and mc.
  • Updates the value of ScintPreScale to reflect the updated value of the PMT detection efficiencies.
  • Introduces the new $\eta_{PMT}$ calibration curve for MC after updating PMT detection efficiencies in previous PRs.
  • Introduces an independent $\eta_{PMT}$ calibration curve for each TPC in data, as it improved the performance of the drift distance reconstruction.
  • Fixes a bug found by @lynnt20 related to readout cable delay simulation. Readout delay is removed to reconcile the timing scheme with the the one used in the previous version of the PTM MC.
  • Fixes a bug found by @lynnt20 related to PMT detsim simulation. Channel 249 was being erroneously simulated. It has been fixed by updating the pds_calibration.db file.
  • Updates the PMT deconvolution module to make use of the calibration database to decide wether tor reconstruct a channel or not instead of using a fcl-configurable list.

Please provide a detailed description of the changes this pull request introduces.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
This PR is to be merged with SBNSoftware/sbnd_data#8

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@asanchezcastillo asanchezcastillo self-assigned this Dec 11, 2025
@asanchezcastillo asanchezcastillo marked this pull request as ready for review December 11, 2025 20:55
@asanchezcastillo asanchezcastillo added bug Something isn't working reco1/reco2 Reconstruction labels Dec 11, 2025
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production Dec 11, 2025
@asanchezcastillo asanchezcastillo marked this pull request as draft December 15, 2025 11:21
@asanchezcastillo asanchezcastillo marked this pull request as ready for review December 17, 2025 12:37
asanchezcastillo and others added 3 commits December 17, 2025 06:46
`fPositivePolarity` is inferred during configuration
Copy link
Contributor

@lynnt20 lynnt20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, also pushed a couple changes myself:

  1. updated pmtmcmetric input label to be with the pulse oscillations.
  2. removed some unused variables mentioned in last major PR #876 by @fjnicolas.

Would be good to get @fjnicolas's review before merging.

Copy link
Contributor

@fjnicolas fjnicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asanchezcastillo! Looks good from my side and all the changes match the PR description :)

@linyan-w linyan-w moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production Dec 17, 2025
@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_14_00_01 LArSoft/lar*@LARSOFT_SUITE_v10_14_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

Approved!

@nathanielerowe nathanielerowe merged commit e4f3ea2 into develop Dec 18, 2025
3 of 4 checks passed
@linyan-w linyan-w moved this from Reviewer Approved to In tagged release in SBND 2025 Fall Production Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working reco1/reco2 Reconstruction

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

6 participants