Skip to content

Fixed scope of ObjectModel.semanticKey to be valid on Entity, not Type level #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maiargu merged 13 commits into from
May 15, 2025
Merged

Fixed scope of ObjectModel.semanticKey to be valid on Entity, not Type level #89

maiargu merged 13 commits into from
May 15, 2025

Conversation

@Fannon
Copy link
Member

@Fannon Fannon commented May 13, 2025 •
edited
Loading

Looks like the scope was defined wrong, it's a list of the elements (element ref) that is defined on entity level

@Fannon
Fixed scope of ObjectModel.semanticKey to be valid on Entity, not Typ…
66b1387 
…e level

Signed-off-by: Simon Heimler <simon.heimler@sap.com>
@Fannon Fannon self-assigned this May 13, 2025
@Fannon
run generate
234cf23 
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
@Fannon Fannon requested a review from maiargu May 13, 2025 08:08
maiargu
maiargu reviewed May 13, 2025
View reviewed changes
michaelbelenki
michaelbelenki approved these changes May 13, 2025
View reviewed changes
Copy link

@michaelbelenki michaelbelenki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the annotation ObjectModel.semanticKey is valid on entity level

Fannon and others added 2 commits May 13, 2025 12:39
@Fannon @maiargu
Update spec/v1/annotations/object-model.yaml
687197a 
Co-authored-by: Raluca Gruber <92865676+maiargu@users.noreply.github.com>
@Fannon
run generate
2cfd609 
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
@Fannon Fannon added this to the 1.0.4 milestone May 13, 2025
Fannon added 3 commits May 13, 2025 12:42
@Fannon
Prepare for v1.0.4 release
0d5e118 
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
@Fannon
Migrate to latest json-schema-library (breaking changes)
5347021 
Signed-off-by: Simon Heimler <simon.heimler@sap.com>
@Fannon
Use rimraf instead of bash rm -rf
d3b9b04
@Fannon Fannon mentioned this pull request May 13, 2025
Draft
@Fannon
Copy link
Member Author

Fannon commented May 13, 2025

@maiargu I undid the dependency upgrade of json-schema-library because it seems to imply that we convert this project (and jest) towards ESM. Let's do that in a separate PR. I tried to keep the changes in #90 , but run into several follow-up problems there.

@maiargu maiargu force-pushed the fix-scope-of-objectmodel-semanticKey branch from fbc2bf3 to 80b2f45 Compare May 14, 2025 09:02
@maiargu maiargu merged commit 5d8470b into main May 15, 2025
3 checks passed
@maiargu maiargu deleted the fix-scope-of-objectmodel-semanticKey branch May 15, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maiargu maiargu maiargu approved these changes

@michaelbelenki michaelbelenki michaelbelenki approved these changes

Assignees

@Fannon Fannon

Labels

None yet

Projects

None yet

Milestone

1.0.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Fannon @maiargu @michaelbelenki