-
Notifications
You must be signed in to change notification settings - Fork 15
fix: request #673 #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: request #673 #678
Conversation
|
|
|
Thanks for the contribution! And it does make sense on first sight. Once we decide to manually adjust generated code (like here) we would find ourself in responsibility to maintain and support it over long time. This is not a commitment we can take as team without management approval at the moment. |
Hello, Kind Regards |
|
One fix could be to extend the API classes, therefore separating the generated class from the extension. |
We use the Cloud SDK OpenAPI generator. You can find related documentation here. This is our wrapper around the OpenAPI generator.
The Your interest and effort is appreciated and strengthens the case first-class grounding module support. |
Context
feat: retrieve chunks with search.
AI/ai-sdk-java-backlog#673
This will fix issue #673 for convenience
Feature scope:
Definition of Done
Aligned changes with the JavaScript SDK