chore: [Orchestration] (and OpenAI) Migrate max_token parameter
#629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
changed the title
max_token parametermax_token parameter
| request = | ||
| request | ||
| .withStop(options.getStopSequences()) | ||
| .withMaxCompletionTokens(options.getMaxTokens()); |
Contributor
There was a problem hiding this comment.
Why change OpenAI, I thought only orchestration deprecated it.
Contributor
Author
There was a problem hiding this comment.
Apparently we didn't even notice that OpenAI deprecated the field last year 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Orchestration BLI
https://github.tools.sap/AI/llm-orchestration/issues/1764
Announcement
https://sap-ml.slack.com/archives/C090TSZ2M1N/p1761228331127799
Discussion
https://sap-ml.slack.com/archives/C070WHEH35L/p1761295434796079
Not changing documented / public API
Definition of Done
Aligned changes with the JavaScript SDKDocumentation updatedRelease notes updated(housekeeping)