React/level #37
Merged
React/level #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brayan-724
approved these changes
Jun 19, 2025
Member
Brayan-724
left a comment
Brayan-724
left a comment
There was a problem hiding this comment.
withAs is a good utility, thank you! LGTM
| @@ -0,0 +1,26 @@ | |||
| import { withAs } from "../../utils/hoc/with-as.hoc"; | |||
Member
There was a problem hiding this comment.
Probably we need path aliases for this, like @utils/hoc or @utils/tw-merge
Contributor
Author
There was a problem hiding this comment.
Sure! I'll add path aliases in the next commit :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Related to #22
Summary
Add a new Level React component with the variants from the design spec.
Details
Checks
Passes pnpm lint
Type-safe (pnpm check:tsc)
Integrated into showcase/App.tsx
Screenshots