Fix gaps in SPLICE implementation for instructor dashboard #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnmnetp
reviewed
Dec 19, 2025
components/rsptx/build_tools/core.py
Outdated
| idchild = dynamic.attrib["id"] | ||
| qtype = dynamic.attrib["data-component"] | ||
| # well maybe not... | ||
| else: |
Member
There was a problem hiding this comment.
I think this whole else block is not needed given the updated format for the manifest.
Author
There was a problem hiding this comment.
Sounds good, I can remove the else block here! Will the qtype be properly set to "splice" with the updated manifest format?
Member
|
I would like to merge the dashboard pieces as others will benefit from them. I can fix up the change to the else clause. But I'll wait for you to move this out of draft status. |
Author
|
@bnmnetp I've moved the PR out of draft stage, and removed the |
sarangjo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SPLICE-relevant code to parts of the instructor dashboard that currently don't have support for SPLICE interactive exercises.