Implement Eq trait #341
Open
Implement Eq trait #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures if we ever added another variant, we would have to consider the variants in PartialEq.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302.
Note that the discussion in that issue is really an argument that Store's PartialEq is transitive, in light of the new Run store type. Array can equal Run, and Run can equal Bitmap, but Array != Bitmap always. But if you have an array and a bitmap then the lengths are different, so at least one of A==R or R==B must also be false for any given R and you don't violate transitivity. Essentially the PartialEq is valid, which is a prereq to Eq.
We're adding Eq, and for that all you need to know is that a store will equal itself. We handle A==A, B==B and R==R just fine.