-
Notifications
You must be signed in to change notification settings - Fork 4
feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RenzoPrats
wants to merge
8
commits into
feat/AB#80876-add-geographic-context-in-page
Choose a base branch
from
feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
base: feat/AB#80876-add-geographic-context-in-page
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
05b4d6c
feat: started to add geographic context
RenzoPrats 9759dd1
feat: continued allow to use region and contry context with element o…
RenzoPrats 2089698
feat: finished geographic context
RenzoPrats 7b3dbac
fix: lint
RenzoPrats 22c0057
Merge branch 'feat/AB#80876-add-geographic-context-in-page' of github…
unai-reliefapp a3e842b
feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
unai-reliefapp e4ee7a2
feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
unai-reliefapp 706d395
fix: removed useless code
RenzoPrats File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RenzoPrats , this is the only thing that I don't get, why set
&& 'geography'in the condition, that is always true right? Is it necessary?Besides that looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @unai-reliefapp, indeed it was useless I think I misspelled it, it's already fixed, thank you!