Add rubocop to CI build #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Metrics/AbcSize. - RSpec/NestedGroups
So we don't accidentally introduce violations.
Test coverage: 100.0% |
grega
approved these changes
Apr 17, 2025
Member
grega
left a comment
grega
left a comment
There was a problem hiding this comment.
Thanks 👍 (no need to update the changelog here either, I don't think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some existing rubocop violations via the auto-correct mechanism and then adds rubocop to the CI build as an extra step in the "test" job, but only executing for Ruby v3.3 and Rails v7.2 (currently the latest version of each being tested).