chore: Add type: "module" to package.json
#611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that .js files will by default be interpreted as ESM rather than CJS—which is correct, since almost all our source files are in fact ES modules using import. This allows removal of test/webdriverio/test/package.json, which was preventing npm scripts (e.g. "npm test") from working properly in that directory. A few config files that do in fact use require() are renamed to .cjs to ensure they are correctly interpreted.
cpcallen
requested review from
BenHenning and
maribethb
and removed request for
a team and
BenHenning
maribethb
approved these changes
Jun 23, 2025
Collaborator
maribethb
left a comment
maribethb
left a comment
There was a problem hiding this comment.
LGTM, you mentioned you wanted to check the packaged output to make sure that was correct still, were you able to do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that
.jsfiles will by default be interpreted as ESM rather than CJS—which is correct, since almost all our source files are in fact ES modules usingimport.This allows removal of
test/webdriverio/test/package.json, which was preventing npm scripts (e.g.npm test) from working properly in that directory.A few config files that do in fact use
require()are renamed to.cjsto ensure they are correctly interpreted.