feat: add some basic support for q10 #692
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lash-L
changed the title
allenporter
reviewed
Dec 19, 2025
Contributor
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
I think it would be helpful to try to break this down into the smaller parts. Having the overall big picture is helpful but i think we can review and merge faster doing one chunk at a time?
If there are major changes influencing the design here worth calling out let me know.
| if self._unsub: | ||
| self._unsub() | ||
| self._unsub = None | ||
| close_trait = getattr(self._trait, "close", None) |
Contributor
There was a problem hiding this comment.
I would say add this to the trait protoocl and make it a no-op for the others.
| def _on_message(self, message: RoborockMessage) -> None: | ||
| """Handle incoming messages from the device.""" | ||
| self._logger.debug("Received message from device: %s", message) | ||
| on_message = getattr(self._trait, "on_message", None) |
Contributor
There was a problem hiding this comment.
Let the trait add their own callback.
Lash-L
force-pushed
the
q10_basic_support
branch
from
c38cf4f to
8dca548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally based on top of the Q7 work. Will finish that and then rebase this