Skip to content

fix: ♻️ Make Attachment.save clearer by expliciting that chunksize is non-null #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: ♻️ Make Attachment.save clearer by expliciting that chunksize is non-null #2991

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2da9ef
:recycle: Make `Attachment.save` clearer by expliciting that chunksiz…
Paillat-dev Nov 6, 2025
44a5e7f
Update discord/message.py
Paillat-dev Nov 6, 2025
e2532d9
Update discord/message.py
Paillat-dev Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions discord/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ async def save(
deleted attachments if too much time has passed, and it does not work
on some types of attachments.
chunksize: Optional[:class:`int`]
The maximum size of each chunk to process.
The maximum size of each chunk to process. Must be a positive integer.

Returns
-------
Expand All @@ -336,7 +336,7 @@ async def save(
data = await self.read(use_cached=use_cached)

if isinstance(fp, io.BufferedIOBase):
if chunksize:
if chunksize is not None:
written = 0
async for chunk in data:
written += fp.write(chunk)
Expand All @@ -347,7 +347,7 @@ async def save(
return written
else:
with open(fp, "wb") as f:
if chunksize:
if chunksize is not None:
written = 0
async for chunk in data:
written += f.write(chunk)
Expand Down Expand Up @@ -400,7 +400,7 @@ async def read_chunked(
Parameters
----------
chunksize: :class:`int`
The maximum size of each chunk to process.
The maximum size of each chunk to process. Must be a positive integer.
use_cached: :class:`bool`
Whether to use :attr:`proxy_url` rather than :attr:`url` when downloading
the attachment. This will allow attachments to be saved after deletion
Expand Down