Implement reading of times for PieceWiseLinearMixin, and fix netlist generation #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fix Travis build)
Since Python 3.7, dict.items() guarantees insertion order, but before, the order is undefined. To have reproducible output for tests, the params are now sorted lexicographically.
…d fix Travis build)
Since Python 3.7, dict.items() guarantees insertion order, but before, the order is undefined. To have reproducible output for tests, the params are now sorted lexicographically.
Collaborator
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PieceWiseLinearMixin does not read (time, value) pairs as documented, but expects a list of values of the target unit. The generated netlist does not contain times and is not valid SPICE syntax, as a space is missing.
This PR implements reading a list of (time, value)-tuples and adds a space in the output, so that the generated netlist syntax is acceptable by SPICE (tested with ngSpice 28 and 30).