Do not test the patched copy implementation with Python 3.8+, fixes #421 #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yFilesystem#421 Also stop patching copy with Python 3.8, reverting part of 6f89b81.
althonos
approved these changes
Sep 17, 2020
Member
althonos
left a comment
althonos
left a comment
There was a problem hiding this comment.
Very straightforward, thanks!
lurch
reviewed
Sep 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
This skips the copy tests when it hasn't been patched (i.e. Python 3.8+) while also reverting part of
6f89b81 (do not patch copy for Python 3.8 whose
shutil.copyimplementation uses sendfile).