Skip to content

For Publish operation to ACR, non-anonymous access token should be retrieved #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anamnavi merged 11 commits into from
Dec 5, 2025
Merged

For Publish operation to ACR, non-anonymous access token should be retrieved #1918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
08761ec
For Publish operation to ACR, registry should be deemed unauthenticat…
Dec 1, 2025
bf3ffea
fix version in test
Dec 2, 2025
3ef3f91
fix InformationVariable property accessed in test
Dec 2, 2025
f92f245
check tags first
Dec 2, 2025
a20c753
log more info
Dec 2, 2025
2cd64c8
capture information record output from appropriate stream
Dec 2, 2025
d53f564
add pester test clause for informationRecord not being null
Dec 2, 2025
8d089b2
set internal hook to check when registry may be unauthenticated and c…
Dec 3, 2025
90d3d4d
simply use azAuth indicator bool to check infoRecord
Dec 4, 2025
b1c1005
fix test expected result
Dec 4, 2025
10bb9a8
address feedback - add comment and use InformationVariable in test
Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/code/ContainerRegistryServerAPICalls.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ private Stream InstallVersion(
return null;
}

string containerRegistryAccessToken = GetContainerRegistryAccessToken(needCatalogAccess: false, out errRecord);
string containerRegistryAccessToken = GetContainerRegistryAccessToken(needCatalogAccess: false, isPushOperation: false, out errRecord);
if (errRecord != null)
{
return null;
Expand Down Expand Up @@ -380,7 +380,7 @@ private Stream InstallVersion(
/// If no credential provided at registration then, check if the ACR endpoint can be accessed without a token. If not, try using Azure.Identity to get the az access token, then ACR refresh token and then ACR access token.
/// Note: Access token can be empty if the repository is unauthenticated
/// </summary>
internal string GetContainerRegistryAccessToken(bool needCatalogAccess, out ErrorRecord errRecord)
internal string GetContainerRegistryAccessToken(bool needCatalogAccess, bool isPushOperation, out ErrorRecord errRecord)
{
_cmdletPassedIn.WriteDebug("In ContainerRegistryServerAPICalls::GetContainerRegistryAccessToken()");
string accessToken = string.Empty;
Expand Down Expand Up @@ -408,7 +408,10 @@ internal string GetContainerRegistryAccessToken(bool needCatalogAccess, out Erro
}
else
{
bool isRepositoryUnauthenticated = IsContainerRegistryUnauthenticated(Repository.Uri.ToString(), needCatalogAccess, out errRecord, out accessToken);
// A container registry repository is determined to be unauthenticated if it allows anonymous pull access. However, push operations always require authentication.
bool isRepositoryUnauthenticated = isPushOperation ? false : IsContainerRegistryUnauthenticated(Repository.Uri.ToString(), needCatalogAccess, out errRecord, out accessToken);
_cmdletPassedIn.WriteInformation($"Value of isRepositoryUnauthenticated: {isRepositoryUnauthenticated}", new string[] { "PSRGContainerRegistryUnauthenticatedCheck" });

_cmdletPassedIn.WriteDebug($"Is repository unauthenticated: {isRepositoryUnauthenticated}");

if (errRecord != null)
Expand Down Expand Up @@ -1330,7 +1333,7 @@ internal bool PushNupkgContainerRegistry(

// Get access token (includes refresh tokens)
_cmdletPassedIn.WriteVerbose($"Get access token for container registry server.");
var containerRegistryAccessToken = GetContainerRegistryAccessToken(needCatalogAccess: false, out errRecord);
var containerRegistryAccessToken = GetContainerRegistryAccessToken(needCatalogAccess: false, isPushOperation: true, out errRecord);
if (errRecord != null)
{
return false;
Expand Down Expand Up @@ -1795,7 +1798,7 @@ private Hashtable[] FindPackagesWithVersionHelper(string packageName, VersionTyp
string packageNameLowercase = packageName.ToLower();

string packageNameForFind = PrependMARPrefix(packageNameLowercase);
string containerRegistryAccessToken = GetContainerRegistryAccessToken(needCatalogAccess: false, out errRecord);
string containerRegistryAccessToken = GetContainerRegistryAccessToken(needCatalogAccess: false, isPushOperation: false,out errRecord);
if (errRecord != null)
{
return emptyHashResponses;
Expand Down Expand Up @@ -1907,7 +1910,7 @@ private FindResults FindPackages(string packageName, bool includePrerelease, out
{
_cmdletPassedIn.WriteDebug("In ContainerRegistryServerAPICalls::FindPackages()");
errRecord = null;
string containerRegistryAccessToken = GetContainerRegistryAccessToken(needCatalogAccess: true, out errRecord);
string containerRegistryAccessToken = GetContainerRegistryAccessToken(needCatalogAccess: true, isPushOperation: false, out errRecord);
if (errRecord != null)
{
return emptyResponseResults;
Expand Down
19 changes: 19 additions & 0 deletions test/PublishPSResourceTests/PublishPSResourceContainerRegistryServer.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,25 @@ Describe "Test Publish-PSResource" -tags 'CI' {
$results[0].Version | Should -Be $correctVersion
}

It "Publish a package should always require authentication" {
$version = "15.0.0"
New-ModuleManifest -Path (Join-Path -Path $script:PublishModuleBase -ChildPath "$script:PublishModuleName.psd1") -ModuleVersion $version -Description "$script:PublishModuleName module"

Publish-PSResource -Path $script:PublishModuleBase -Repository $ACRRepoName -InformationVariable RegistryUnauthenticated

$results = Find-PSResource -Name $script:PublishModuleName -Repository $ACRRepoName
$results | Should -Not -BeNullOrEmpty
$results[0].Name | Should -Be $script:PublishModuleName
$results[0].Version | Should -Be $version

if ($usingAzAuth)
{
$RegistryUnauthenticated | Should -Not -BeNullOrEmpty
$RegistryUnauthenticated[0].Tags | Should -Be "PSRGContainerRegistryUnauthenticatedCheck"
$RegistryUnauthenticated[0].MessageData | Should -Be "Value of isRepositoryUnauthenticated: False"
}
}

It "Publish a script"{
$scriptVersion = "1.0.0"
$params = @{
Expand Down
Loading