-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Oanda - fix weekday name #19350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Oanda - fix weekday name #19350
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
WalkthroughPackage and component metadata versions were incremented across several OANDA action/source modules and the package, and a typo in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (3)
Comment |
lcaresia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lcaresia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @verhovsky, since the shared file constants.mjs was modified, all dependency versions need to be updated. Just run the command below in the project root folder and it will automatically bump the versions for you.
sed -i 0,/0.0.2/{s/0.0.2/0.0.3/} components/oanda/actions/create-order/create-order.mjs \
&& sed -i 0,/0.0.2/{s/0.0.2/0.0.3/} components/oanda/actions/list-trades/list-trades.mjs \
&& sed -i 0,/0.0.1/{s/0.0.1/0.0.2/} components/oanda/sources/new-transaction/new-transaction.mjs
lcaresia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi, this is just a typo fix so I'll move this to ready for release |
The upstream API expects it to be spelled correctly
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.