Skip to content

Conversation

@verhovsky
Copy link
Contributor

@verhovsky verhovsky commented Dec 2, 2025

The upstream API expects it to be spelled correctly

Summary by CodeRabbit

  • Bug Fixes

    • Corrected a spelling error in weekly alignment configuration ("Thursday").
  • Chores

    • Bumped package release to 0.7.1.
    • Updated version metadata for several OANDA components and actions.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit Ignored Ignored Dec 3, 2025 11:54am

@pipedream-component-development
Copy link
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development
Copy link
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

Walkthrough

Package and component metadata versions were incremented across several OANDA action/source modules and the package, and a typo in WEEKLY_ALIGNMENT_DAYS was corrected.

Changes

Cohort / File(s) Summary
Package version
components/oanda/package.json
Bumped package version from 0.7.0 to 0.7.1.
Action/source metadata version bumps
components/oanda/actions/get-historical-prices/get-historical-prices.mjs, components/oanda/actions/create-order/create-order.mjs, components/oanda/actions/list-trades/list-trades.mjs, components/oanda/sources/new-transaction/new-transaction.mjs
Updated exported version fields: actions/source metadata bumped from 0.0.1/0.0.2 to 0.0.2/0.0.3 as applicable (no logic changes).
Constants fix
components/oanda/common/constants.mjs
Fixed typo in WEEKLY_ALIGNMENT_DAYS: "Thrusday""Thursday" (no other logic changes).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to components/oanda/common/constants.mjs to confirm no other typos or related data issues.
  • Quick sanity-check of the version-only edits in action/source files to ensure no accidental code changes were included.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Oanda - fix weekday name' clearly and specifically describes the main change: fixing a misspelled weekday name in the OANDA component.
Description check ✅ Passed The description explains the reason for the fix (upstream API expects correct spelling) and references the OANDA API documentation, though it does not follow the repository's template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5773462 and 5d0aef0.

📒 Files selected for processing (3)
  • components/oanda/actions/create-order/create-order.mjs (1 hunks)
  • components/oanda/actions/list-trades/list-trades.mjs (1 hunks)
  • components/oanda/sources/new-transaction/new-transaction.mjs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: pnpm publish
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Lint Code Base
🔇 Additional comments (3)
components/oanda/actions/list-trades/list-trades.mjs (1)

8-8: LGTM!

Version bump appropriately aligns this action with the constants spelling fix.

components/oanda/actions/create-order/create-order.mjs (1)

8-8: LGTM!

Version bump appropriately aligns this action with the constants spelling fix.

components/oanda/sources/new-transaction/new-transaction.mjs (1)

10-10: LGTM!

Version bump appropriately aligns this source with the constants spelling fix.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@lcaresia lcaresia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcaresia lcaresia moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Dec 2, 2025
@lcaresia lcaresia moved this from Ready for QA to Ready for PR Review in Component (Source and Action) Backlog Dec 2, 2025
Copy link
Collaborator

@lcaresia lcaresia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @verhovsky, since the shared file constants.mjs was modified, all dependency versions need to be updated. Just run the command below in the project root folder and it will automatically bump the versions for you.

sed -i 0,/0.0.2/{s/0.0.2/0.0.3/} components/oanda/actions/create-order/create-order.mjs \
&& sed -i 0,/0.0.2/{s/0.0.2/0.0.3/} components/oanda/actions/list-trades/list-trades.mjs \
&& sed -i 0,/0.0.1/{s/0.0.1/0.0.2/} components/oanda/sources/new-transaction/new-transaction.mjs

@lcaresia lcaresia self-assigned this Dec 2, 2025
@lcaresia lcaresia moved this from Ready for PR Review to Changes Required in Component (Source and Action) Backlog Dec 2, 2025
@verhovsky verhovsky requested a review from lcaresia December 2, 2025 17:56
Copy link
Collaborator

@lcaresia lcaresia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcaresia lcaresia moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Dec 3, 2025
@vunguyenhung
Copy link
Collaborator

Hi, this is just a typo fix so I'll move this to ready for release

@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for Release in Component (Source and Action) Backlog Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Release

Development

Successfully merging this pull request may close these issues.

4 participants