Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Dec 1, 2025

Followup to #19231

Summary by CodeRabbit

  • New Features

    • Added destination drive selection option to the create-document-from-template action, allowing users to specify where documents are created.
  • Chores

    • Updated component and dependency versions for improved compatibility and stability.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Dec 1, 2025 4:10pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Dec 1, 2025 4:10pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Walkthrough

The pull request bumps the Google Docs package version and its Google Drive dependency, adds a new destinationDrive property to the create-document-from-template action, and remaps the folderId prop to use this new property instead of the original drive reference.

Changes

Cohort / File(s) Change Summary
Create Document from Template Action
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs
Version bumped from 0.0.7 to 0.0.8. Added new optional destinationDrive prop (Destination Drive). Updated folderId prop mapping from drive: c.drive to drive: c.destinationDrive.
Google Docs Package
components/google_docs/package.json
Package version bumped from 0.6.2 to 0.6.3. @pipedream/google_drive dependency updated from ^1.3.1 to ^1.4.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify the new destinationDrive prop is correctly wired to the folderId mapping
  • Confirm the dependency version bump (^1.3.1 to ^1.4.1) is compatible with the action changes

Possibly related PRs

Suggested reviewers

  • GTFalcao
  • luancazarine

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal, only referencing a prior issue without explaining the purpose or context of this follow-up. Expand the description to explain why this change is needed, what problem it solves, and what the key changes accomplish.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding support for storing created documents in a shared drive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-19231-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ad1bce and fb4cdfa.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (2 hunks)
  • components/google_docs/package.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
  • GitHub Check: pnpm publish
  • GitHub Check: Lint Code Base
🔇 Additional comments (2)
components/google_docs/package.json (1)

3-18: Version and @pipedream/google_drive bump look consistent—please confirm compatibility testing

The package version bump to 0.6.3 and dependency bump to @pipedream/google_drive@^1.4.1 are consistent with the action changes. Please make sure the updated Google Drive component’s watchedDrive / folderId behavior has been exercised by existing workflows using this package (especially create‑document‑from‑template) to rule out regressions tied to the dependency upgrade.

components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (1)

16-18: Action version bump to 0.0.8 is straightforward

The version increment to "0.0.8" matches the addition of a new public prop and behavior tweak, and keeps the action key stable, which is appropriate for backward‑compatible changes.

Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GTFalcao GTFalcao moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Dec 1, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for Release in Component (Source and Action) Backlog Dec 3, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test reports

@michelle0927 michelle0927 merged commit 6edbfe7 into master Dec 3, 2025
10 checks passed
@michelle0927 michelle0927 deleted the issue-19231-2 branch December 3, 2025 15:35
@github-project-automation github-project-automation bot moved this from Ready for Release to Done in Component (Source and Action) Backlog Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants