-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add ticket status actions to Frontapp component #19224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Introduced new actions for retrieving and listing ticket statuses. - Added `getTicketStatus` and `listTicketStatuses` methods to the Frontapp component. - Enhanced prop definitions for ticket status ID with async options for better integration. - Updated documentation links for the new actions to improve usability.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Warning Rate limit exceeded@luancazarine has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 24 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdds ticket-status support for the FrontApp integration: two new actions (list and get ticket statuses) and corresponding app methods and a propDefinition in the FrontApp app module to list and fetch company ticket statuses. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Action as Action (list/get ticket statuses)
participant App as FrontApp app
participant API as Front API (/company/statuses)
Note over Action,App: Start action run()
Action->>App: call listTicketStatuses({ $ }) or getTicketStatus({ ticketStatusId, $ })
activate App
App->>API: GET /company/statuses or GET /company/statuses/{id}
API-->>App: 200 OK (statuses or status)
deactivate App
App-->>Action: returns response
Note over Action: action exports summary and returns API response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
components/frontapp/actions/get-ticket-status/get-ticket-status.mjs(1 hunks)components/frontapp/actions/list-ticket-statuses/list-ticket-statuses.mjs(1 hunks)components/frontapp/frontapp.app.mjs(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
🔇 Additional comments (4)
components/frontapp/actions/list-ticket-statuses/list-ticket-statuses.mjs (1)
1-26: List Ticket Statuses action matches existing patterns and looks correct
- Imports the app, wires
frontAppprop, callsthis.frontApp.listTicketStatuses({ $ }), and returns_resultswith a clear$summary.- Summary pluralization and read‑only annotations are appropriate.
components/frontapp/frontapp.app.mjs (2)
514-521: getTicketStatus helper matches existing method conventions
getTicketStatusis a thin wrapper aroundmakeRequest, taking{ ticketStatusId, ...args }and building the expected/company/statuses/{ticketStatusId}path, consistent with othergetXmethods in this app.
528-533: listTicketStatuses helper is consistent with other list helpers
listTicketStatusessimply callsmakeRequestwith the/company/statusespath and forwards options. This matches the structure oflistTags,listTeammates, etc., so pagination and option loading viapaginateOptionswill work as expected.components/frontapp/actions/get-ticket-status/get-ticket-status.mjs (1)
1-31: Get Ticket Status action is correctly implemented and integrated
- Reuses the shared
ticketStatusIdpropDefinition, ensuring options come fromlistTicketStatuses.- Calls the new
getTicketStatushelper and exports a concise, informative$summary.- Typing, annotations, and structure align with other Front actions.
…functionality - Bumped version numbers for various actions including add-comment, archive-conversation, assign-conversation, create-draft, create-draft-reply, get-comment, and others to 0.0.6. - Updated create-inbox, list-message-templates, and get-message versions to 0.0.5. - Increased import-message and update-conversation versions to 0.1.12 and 0.1.11 respectively. - Enhanced new-conversation-created and new-message-template-created versions to 0.0.6. - Incremented new-conversation-state-change and new-conversation-tag versions to 0.0.8. - Ensured all changes align with the latest documentation and improve overall integration.
lcaresia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
Resolves #19179
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.