Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Nov 17, 2025

Followup to Issue #18958, PR #19053

Adds changes to support templates in shared drives for Google Docs - Create File From Template

Summary by CodeRabbit

  • New Features

    • Added optional Drive selection parameter for document creation workflows.
    • Added optional Folder selection parameter to specify where newly created documents are stored.
  • Chores

    • Updated component version and dependencies.

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Nov 17, 2025 6:45pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Nov 17, 2025 6:45pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Walkthrough

The changes add drive and folder selection functionality to the Google Docs create-document-from-template action. A new optional drive prop and optional folderId prop are introduced, with templateId updated to reference drive context. The package version is incremented and the Google Drive dependency is updated.

Changes

Cohort / File(s) Summary
Create Document from Template Configuration
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs
Version bumped to 0.0.7. New optional drive prop added with watchedDrive definition. templateId extended with drive context dependency. New optional folderId prop added for folder selection.
Package Dependencies
components/google_docs/package.json
Version bumped to 0.6.2. @pipedream/google_drive dependency updated from ^1.1.1 to ^1.3.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Prop definitions follow consistent patterns with existing code conventions
  • Simple version bumps and dependency updates
  • No logic or control flow modifications

Suggested reviewers

  • luancazarine

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context by referencing the related issue and previous PR, but lacks detail on the specific implementation changes and their impact. Expand the description to explain what changes were made (e.g., new drive/folder selection props) and how they enable shared drive template support.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change—adding support for templates in shared drives to the Google Docs Create File From Template action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-18958-2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4a853e and 382459d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (1 hunks)
  • components/google_docs/package.json (2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (1)
components/google_docs/actions/find-document/find-document.mjs (1)
  • props (11-11)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: pnpm publish
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Lint Code Base
🔇 Additional comments (5)
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (4)

16-16: LGTM!

The version bump is appropriate for this feature addition.


22-28: LGTM!

The drive prop is correctly configured as optional and properly references the watchedDrive propDefinition to enable shared drive selection.


33-35: LGTM!

The drive context is correctly added to enable filtering templates from the selected shared drive.


41-52: No issues found - parameter naming is intentional and correct.

The original review comment flagged an apparent inconsistency where templateId uses driveId: c.drive and folderId uses drive: c.drive. Verification confirms this is intentional and correct:

  • templateId calls the google_docs app's docId propDefinition, which expects a parameter named driveId
  • folderId calls the google_drive app's folderId propDefinition, which expects a parameter named drive

Each context function properly passes the parameter name that its respective propDefinition requires. The parameter names differ because they're calling different apps' APIs with different signatures.

components/google_docs/package.json (1)

3-3: Verification complete—dependency is available and compatible.

The Google Drive dependency version 1.3.1 is published and includes the required propDefinitions:

  • watchedDrive propDefinition for drive selection
  • folderId propDefinition with drive context callback support

The version bump is appropriate and introduces no compatibility issues.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GTFalcao GTFalcao moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants