-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Hostaway new action #14825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hostaway new action #14825
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
76 changes: 76 additions & 0 deletions
76
components/hostaway/actions/create-reservation/create-reservation.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| import hostaway from "../../hostaway.app.mjs"; | ||
|
|
||
| export default { | ||
| key: "hostaway-create-reservation", | ||
| name: "Create Reservation", | ||
| description: "Creates a new reservation in Hostaway. [See the documentation](https://api.hostaway.com/documentation#create-a-reservation)", | ||
| version: "0.0.1", | ||
| type: "action", | ||
| props: { | ||
| hostaway, | ||
| channelId: { | ||
| propDefinition: [ | ||
| hostaway, | ||
| "channelId", | ||
| ], | ||
| }, | ||
| listingMapId: { | ||
| propDefinition: [ | ||
| hostaway, | ||
| "listingId", | ||
| ], | ||
| }, | ||
| arrivalDate: { | ||
| type: "string", | ||
| label: "Arrival Date", | ||
| description: "Arrival date in `YYYY-MM-DD` format, e.g. `2024-08-15`", | ||
| }, | ||
| departureDate: { | ||
| type: "string", | ||
| label: "Departure Date", | ||
| description: "Departure date in `YYYY-MM-DD` format, e.g. `2024-08-19`", | ||
| }, | ||
| guestName: { | ||
| type: "string", | ||
| label: "Guest Name", | ||
| description: "Name of the guest", | ||
| optional: true, | ||
| }, | ||
| guestEmail: { | ||
| type: "string", | ||
| label: "Guest Email", | ||
| description: "Email address of the guest", | ||
| optional: true, | ||
| }, | ||
| numberOfGuests: { | ||
| type: "integer", | ||
| label: "Number of Guests", | ||
| description: "Number of guests for the reservation", | ||
| optional: true, | ||
| }, | ||
| additionalFields: { | ||
| type: "object", | ||
| label: "Additional Fields", | ||
| description: "Additional fields to set for the reservation. [See the documentation](https://api.hostaway.com/documentation#reservation-object) for all available fields.", | ||
| optional: true, | ||
| }, | ||
| }, | ||
| async run({ $ }) { | ||
| const { | ||
| hostaway, additionalFields = {}, ...data | ||
| } = this; | ||
| const { result } = await hostaway.createReservation({ | ||
| $, | ||
| data: { | ||
| ...data, | ||
| ...additionalFields, | ||
| }, | ||
| }); | ||
|
|
||
| if (result?.id) { | ||
| $.export("summary", `Successfully created reservation (ID: ${result.id})`); | ||
| } | ||
|
|
||
| return result; | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add date validation for arrival and departure dates
While the date format is documented, there's no validation to ensure dates are:
Consider adding validation in the run method:
async run({ $ }) { const { hostaway, additionalFields = {}, ...data } = this; + const arrival = new Date(data.arrivalDate); + const departure = new Date(data.departureDate); + + if (isNaN(arrival.getTime()) || isNaN(departure.getTime())) { + throw new Error("Invalid date format. Use YYYY-MM-DD"); + } + + if (arrival >= departure) { + throw new Error("Arrival date must be before departure date"); + } + + if (arrival < new Date()) { + throw new Error("Arrival date cannot be in the past"); + } const { result } = await hostaway.createReservation({