Skip to content

Fix homes retrieval when there's no "share_home_list" #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix homes retrieval when there's no "share_home_list" #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f6e6b2
Fix homes retrieval when there's no 'share_home_list'.
hbeaufils Jul 20, 2025
c32ace8
Add error log to indicate a failure to find the device specified in t…
hbeaufils Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion custom_components/xiaomi_cloud_map_extractor/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,12 @@ def _handle_login(self):

def _handle_device(self):
_LOGGER.debug("Retrieving device info, country: %s", self._country)
country, user_id, device_id, model = self._connector.get_device_details(self._vacuum.token, self._country)
token = self._vacuum.token
country, user_id, device_id, model = self._connector.get_device_details(token, self._country)

if device_id is None:
_LOGGER.error("Failed to find a device matching the given token: %s", token)

if model is not None:
self._country = country
_LOGGER.debug("Retrieved device model: %s", model)
Expand Down
6 changes: 4 additions & 2 deletions custom_components/xiaomi_cloud_map_extractor/common/xiaomi_cloud_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,12 @@ def get_homes_iter(self, country: str):
if (response := self.execute_api_call_encrypted(url, params)) is None:
return None

if homelist := response["result"]["homelist"]:
result = response["result"]

if homelist := result["homelist"]:
yield from (XiaomiHome(int(home["id"]), home["uid"]) for home in homelist)

if homelist := response["result"]["share_home_list"]:
if homelist := result.get("share_home_list", None):
yield from (XiaomiHome(int(home["id"]), home["uid"]) for home in homelist)

def get_devices_from_home_iter(self, country: str, home_id: int, owner_id: int):
Expand Down