-
-
Notifications
You must be signed in to change notification settings - Fork 172
Feature custom data source synonyms / labels #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature custom data source synonyms / labels #1079
Conversation
|
I finally found time to take a look at your PR. However, some smaller things should be fixed before merging:
|
Die Spracheinstellungen/System-Settings wurden um die Möglichkeit ergänzt, bevorzugte Sprachen für die Dropdown-Menüs festzulegen. Zudem wurde ein Datenquellen-Synonymsystem implementiert, um benutzerfreundlichere Bezeichnungen anzuzeigen und zu personalisieren.
Die Verwaltung der Datenquellen-Synonyme wurde überarbeitet, um ein flexibleres und strukturiertes Konzept zu ermöglichen. Der bestehende JSON-basierte Ansatz wurde durch eine neue Service-basierte Architektur ersetzt, die eine bessere Handhabung und Erweiterbarkeit erlaubt.
7c24e18 to
a8b3dce
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
============================================
- Coverage 58.70% 58.40% -0.31%
- Complexity 7173 7275 +102
============================================
Files 574 579 +5
Lines 22892 23147 +255
============================================
+ Hits 13438 13518 +80
- Misses 9454 9629 +175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…den vom Nutzer freigeschalteten.
The tag is applied via autoconfiguration
|
I changed some things about the PR (in a way that you will need to redefine the synonyms):
So if you have defined a translation like "Create new [category]" it will become "Create new category" if you have no synonym defined, and "Create new my synonym" if there is a custom type synonym defined. The type values can be found inside the ElementTypes enum. For every type there are 4 placeholders/versions defined:
|

Hello @jbtronics,
In relation to #1051 the feature custom data source synonyms / labels.
Also mentioned in the discussion under #1041, section 1.
A preferred language selection and a configuration option for data source synonyms for the Part DB data sources were created under the System Settings. The data source synonym system is intended to display user-friendly and use-case-related names for data sources – for example, in the sidebar/treeview – and ultimately to "personalize" them.
In the future I would add this to the Part-DB-project following the integration, analogous for assemblies (a feature PR for this will follow), and users can then decide how to visually name the data sources for assemblies also.
I have therefore initially left out assemblies as a data source consideration in this PR, as I will divide this into separate PRs.
Thanks for everything so far! I am grateful for integration!
Best regards,
Marcel