Skip to content

feat:你知道吗 #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xrlzu wants to merge 35 commits into
base: dev
Choose a base branch
from
Open

feat:你知道吗 #1927

xrlzu wants to merge 35 commits into from

Conversation

@xrlzu
Copy link
Member

@xrlzu xrlzu commented Nov 23, 2025 •
edited
Loading

素材来自于中文 WIKI

@pcl-ce-automation pcl-ce-automation bot added 🛠️ 等待审查 Pull Request 已完善，等待维护者或负责人进行代码审查 size: L PR 大小评估：大型 labels Nov 23, 2025
@xrlzu xrlzu requested a review from a team November 23, 2025 10:30
ruattd
ruattd previously requested changes Nov 23, 2025
View reviewed changes
Copy link
Contributor

@ruattd ruattd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

虽然不知道来源这些提示到底是从哪里收集来的，但是它们实在太太太太太太不规范了，最基本的需求也至少要遵循基本的大小写和中文/英文/符号中间的空格 (Pangu)

以及有些内容看着就不像是中文，需要改进一下

@CiiLu
Copy link
Member

CiiLu commented Nov 23, 2025

image image 启动时的也需要加回来 并且我感觉你知道吗应该放PCL（CE）相关的

@pcl-ce-automation pcl-ce-automation bot added size: XL PR 大小评估：超大型 and removed size: L PR 大小评估：大型 labels Nov 23, 2025
@xrlzu
Copy link
Member Author

xrlzu commented Nov 23, 2025 •
edited
Loading

并且我感觉你知道吗应该放PCL（CE）相关的

和 CE 相关的估计很难搞，因为根本找不到现成的素材

@xrlzu xrlzu requested review from a team and ruattd November 23, 2025 14:55
ruollin
ruollin previously requested changes Nov 23, 2025
View reviewed changes
Copy link
Member

@ruollin ruollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此外日志需要有 Module Name 以便和其他日志统一（

@xrlzu xrlzu requested review from a team and ruollin November 24, 2025 09:07
@pcl-ce-automation pcl-ce-automation bot added size: L PR 大小评估：大型 and removed size: XL PR 大小评估：超大型 labels Nov 24, 2025
@xrlzu
Copy link
Member Author

xrlzu commented Nov 24, 2025

由于之前的素材可能包含很多错误且没办法一个个准确识别，因此将移除这些内容，新的素材将来自于中文 WIKI 以确保内容的正确性

@xrlzu xrlzu requested a review from copytiao November 29, 2025 03:34
CiiLu
CiiLu previously requested changes Nov 29, 2025
View reviewed changes
Copy link
Member

@CiiLu CiiLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image 内置的hints很多都非常长，无法显示完全

@pcl-ce-automation pcl-ce-automation bot removed the 🛠️ 等待审查 Pull Request 已完善，等待维护者或负责人进行代码审查 label Nov 30, 2025
@xrlzu xrlzu requested review from a team and CiiLu November 30, 2025 03:07
@xrlzu xrlzu dismissed stale reviews from CiiLu, copytiao, ruollin, and ruattd November 30, 2025 07:17

resolved

@xrlzu xrlzu added the 🛠️ 等待审查 Pull Request 已完善，等待维护者或负责人进行代码审查 label Nov 30, 2025
@pcl-ce-automation pcl-ce-automation bot removed the 🛠️ 等待审查 Pull Request 已完善，等待维护者或负责人进行代码审查 label Nov 30, 2025
MoYuan-CN
MoYuan-CN previously approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@MoYuan-CN MoYuan-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，但请等待另一个人检查代码质量

ruollin
ruollin previously requested changes Dec 5, 2025
View reviewed changes
@xrlzu xrlzu requested review from a team and ruollin December 6, 2025 02:30
@xrlzu xrlzu added the 🛠️ 等待审查 Pull Request 已完善，等待维护者或负责人进行代码审查 label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoYuan-CN MoYuan-CN MoYuan-CN left review comments

@ruattd ruattd Awaiting requested review from ruattd

@copytiao copytiao Awaiting requested review from copytiao

@CiiLu CiiLu Awaiting requested review from CiiLu

@ruollin ruollin Awaiting requested review from ruollin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size: XXL PR 大小评估：巨型 🛠️ 等待审查 Pull Request 已完善，等待维护者或负责人进行代码审查

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xrlzu @CiiLu @ruattd @MoYuan-CN @copytiao @ruollin