Deprecate various car types in favor of new alias TYPE_CAR #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmai
added
the
Harmonisation
pmai
added
the
ReadyForCCBReview
jakobkaths
requested changes
Mar 18, 2024
jakobkaths
approved these changes
Mar 22, 2024
pmai
force-pushed
the
harmonization/deprecate-car-types
branch
from
6180640 to
173e7d7
Compare
Contributor
|
The change looks good to me 👍 |
Contributor
Author
|
CCB 2024-04-04: Merge as-is. |
This is a result of the harmonization effort across ASAM Open standards Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Co-authored-by: jakobkaths <54845080+jakobkaths@users.noreply.github.com> Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai
force-pushed
the
harmonization/deprecate-car-types
branch
from
173e7d7 to
7b38bed
Compare
pmai
added
ReadyToMerge
thempen
approved these changes
Apr 4, 2024
Contributor
thempen
left a comment
thempen
left a comment
There was a problem hiding this comment.
The changes let the type better align to other standards. It will still be backward compatible and can be used in the new way through the alias functionality. So I do not see a downside. Therefore I approve this PR.
jdsika
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first result of the harmonization effort across ASAM Open standards
In preparation of additional types we already deprecate some obvious candidates for removal, namely our plethora of car types.