Extension of the hostVehicleData (part 2) #547

ThomasNaderBMW · 2021-06-30T16:03:29Z

Reference to a related issue in the repository

Solves #481 and is the continuation of #441, which broke down after a rebase (I am sorry for that).

Add a description

Host vehicle data is about the perception of the vehicle about it's own, internal states.
It can be understood as an interface container for restbussimulation signals.
If there is a duplication with values from the rest of SensorView or SensorData, than these shall be taken.

It consists of different messages categorizing the vehicle in:
Vehicle-Basics, Vehicle-Powertrain, Vehicle-SteeringWheel, Vehicle-Wheels, Vehicle-Localization.

Some questions to ask:
Does it break any existing functionality or force me to update to a new version?
No, but some fields are deprecated (toDo for 4.0).

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

My suggestion follows the style and contributors guidelines.
I have taken care about the documentation.
I have done the DCO signoff.
My changes generate no errors when passing CI tests.
I have successfully implemented and tested my fix/feature locally.
Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

osi_hostvehicledata.proto

osi_common.proto

osi_hostvehicledata.proto

stefancyliax · 2021-07-13T08:07:52Z

CCB 13.07.2021:
Due to missing participation, PR has to be shifted to next CCB.

kmeids · 2021-07-21T09:52:41Z

CCB Output 21.07.2021

For geodetic reference please check https://opensimulationinterface.github.io/open-simulation-interface/structosi3_1_1GroundTruth.html#af5f78f308a00d74ece79410eb7913006
VehiclePositionAndKinematics message to be revisited within the TrafficParticipants WG.

stefancyliax · 2021-08-04T09:19:44Z

CCB Meeting 04.08.2021:

@ThomasNaderBMW Please update PR or remove milestone. We have to move things forward.

ThomasNaderBMW · 2021-08-23T10:02:23Z

@stefancyliax : Can we give it 10 min in the next CCB?
@kmeids and @pmai : Is it okay like this? I would like to use the chance and bring it into 3.4.

stefancyliax · 2021-08-25T10:24:04Z

OSI CCB:

please correct DCO @ThomasNaderBMW
@everybody please review

kmeids · 2021-09-15T09:43:12Z

osi_common.proto

+}
+
+//
+// \brief The geodetic position of an object, i.e. center of the bounding box.


Suggested change

// \brief The geodetic position of an object, i.e. center of the bounding box.

// \brief The geodetic position of an object, i.e. center of the 3D bounding box.

kmeids · 2021-09-15T09:51:37Z

Output CCB 15.09.2021:

@pasched could you please do a documentation review for the .proto files and set the tag "ReadyToMerge" (please check https://github.com/OpenSimulationInterface/open-simulation-interface/pull/547/files#r709021632)?
@pmai to merge after documentation review.

ThomasNaderBMW · 2021-09-21T16:12:04Z

@FKlopfer : Is it ready to merge? Your change removed the DCO Sign off, do you add it or is an action from my side required?

FKlopfer · 2021-09-22T07:01:59Z

@FKlopfer : Is it ready to merge? Your change removed the DCO Sign off, do you add it or is an action from my side required?

Hi @ThomasNaderBMW , it is ready to merge from my side. There was something wrong in the GitHub configuration regarding the DCO last Friday that @stefancyliax was trying to fix but I do not know how far ge got.

kmeids · 2021-10-13T09:37:56Z

osi_hostvehicledata.proto

+        //
+        // \brief The focus here is on the description of a wheel.
+        //
+        message WheelData


CCB Output 13.10.2021:

@pmai Please update the comment to indicate that this only relevant to the internal wheel data of the vehicle.

I already did the description improvements.

osi_hostvehicledata.proto

ThomasNaderBMW · 2021-10-18T06:36:34Z

Can you check and merge @pmai ?

…the hostVehicleData #441" (before it broke down). Signed-off-by: Nader Thomas <thomas.nader@bmw.de>

Signed-off-by: Nader Thomas <thomas.nader@bmw.de>

Signed-off-by: spider <Thomas.Nader@bmw.de> Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

Changes done to be open for SetLevel4to5 Requirements. Signed-off-by: spider <Thomas.Nader@bmw.de>

Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

ThomasNaderBMW requested review from 0815-code, Krishna626, kmeids and pmai June 30, 2021 16:03

ThomasNaderBMW self-assigned this Jun 30, 2021

ThomasNaderBMW added the TrafficParticipants The group in the ASAM development project working on traffic participants. label Jun 30, 2021

ThomasNaderBMW added this to the V3.4.0 milestone Jun 30, 2021

ThomasNaderBMW linked an issue Jun 30, 2021 that may be closed by this pull request

Shifting of Pedalry, VehicleSteeringWheel and gear_transmission from HostVehicleData (PR#441) to OSI_Common Protofile #481

Closed

This was linked to issues Jul 1, 2021

Add timestamp to host_vehicle_location #463

Closed

Add Gnss and Imu Sensor Measurements #489

Closed

0815-code requested a review from a user July 1, 2021 19:25

0815-code approved these changes Jul 1, 2021

View reviewed changes

osi_hostvehicledata.proto Show resolved Hide resolved

osi_common.proto Show resolved Hide resolved

osi_common.proto Show resolved Hide resolved

osi_common.proto Show resolved Hide resolved

0815-code reviewed Jul 1, 2021

View reviewed changes

osi_hostvehicledata.proto Show resolved Hide resolved

ThomasNaderBMW added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Jul 7, 2021

kmeids removed the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Jul 21, 2021

ThomasNaderBMW added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Aug 23, 2021

ThomasNaderBMW force-pushed the Extension_osi_hostvehicledata_v2 branch from 081c58a to 3c7304e Compare September 13, 2021 18:04

kmeids added Documentation Everything which impacts the quality of the documentation and guidelines. and removed ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels Sep 15, 2021

kmeids reviewed Sep 15, 2021

View reviewed changes

ThomasNaderBMW mentioned this pull request Sep 16, 2021

Extension of the hostVehicleData #441

Closed

6 tasks

FKlopfer force-pushed the Extension_osi_hostvehicledata_v2 branch from ab296c8 to bc7e61e Compare September 17, 2021 09:30

kmeids added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Oct 1, 2021

ThomasNaderBMW force-pushed the Extension_osi_hostvehicledata_v2 branch from 0c084d1 to e973b6f Compare October 11, 2021 11:50

kmeids reviewed Oct 13, 2021

View reviewed changes

caspar-ai reviewed Oct 13, 2021

View reviewed changes

osi_hostvehicledata.proto Show resolved Hide resolved

caspar-ai mentioned this pull request Oct 15, 2021

Add automated driving function state to host vehicle data #589

Merged

6 tasks

pmai force-pushed the Extension_osi_hostvehicledata_v2 branch from a5e2e77 to 2795866 Compare October 19, 2021 10:07

ThomasNaderBMW and others added 8 commits October 19, 2021 12:10

New Branch and update of the necessary changes from PR "Extension of …

fbac8c3

…the hostVehicleData #441" (before it broke down). Signed-off-by: Nader Thomas <thomas.nader@bmw.de>

Updated motor descriptions.

5cc7f94

Signed-off-by: Nader Thomas <thomas.nader@bmw.de>

Updated VehicleLocalization after CCB

0d3bd02

Signed-off-by: spider <Thomas.Nader@bmw.de> Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>

Added geodetic position

9553e7e

Signed-off-by: spider <Thomas.Nader@bmw.de> Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>

Linguistic review

32f6bf9

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

Added VehicleBrakeSystem and changed to VehicleSteering

feaf8f8

Changes done to be open for SetLevel4to5 Requirements. Signed-off-by: spider <Thomas.Nader@bmw.de>

Added host vehicle id and minor description modifications.

9457f11

Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>

Minor clarifications and language corrections

41946d4

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

pmai force-pushed the Extension_osi_hostvehicledata_v2 branch from 2795866 to 41946d4 Compare October 19, 2021 10:13

pmai approved these changes Oct 19, 2021

View reviewed changes

pmai merged commit f5e6992 into master Oct 19, 2021

stefancyliax deleted the Extension_osi_hostvehicledata_v2 branch October 21, 2021 13:23

clemenshabedank mentioned this pull request May 9, 2022

Added ENU coordinate system specifications to HostVehicleData #488

Closed

	// \brief The geodetic position of an object, i.e. center of the bounding box.
	// \brief The geodetic position of an object, i.e. center of the 3D bounding box.

Extension of the hostVehicleData (part 2) #547

Extension of the hostVehicleData (part 2) #547

Uh oh!

Conversation

ThomasNaderBMW commented Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference to a related issue in the repository

Add a description

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stefancyliax commented Jul 13, 2021

Uh oh!

kmeids commented Jul 21, 2021

Uh oh!

stefancyliax commented Aug 4, 2021

Uh oh!

ThomasNaderBMW commented Aug 23, 2021

Uh oh!

stefancyliax commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kmeids Sep 15, 2021

Choose a reason for hiding this comment

Uh oh!

ThomasNaderBMW Oct 18, 2021

Choose a reason for hiding this comment

Uh oh!

kmeids commented Sep 15, 2021

Uh oh!

ThomasNaderBMW commented Sep 21, 2021

Uh oh!

FKlopfer commented Sep 22, 2021

Uh oh!

kmeids Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

ThomasNaderBMW Oct 18, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ThomasNaderBMW commented Oct 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ThomasNaderBMW commented Jun 30, 2021 •

edited

Loading

stefancyliax commented Aug 25, 2021 •

edited

Loading