Skip to content

Fix: IAM with NOT_EQUAL_TO trigger always shows up #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinliu9508 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: IAM with NOT_EQUAL_TO trigger always shows up #2509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ges/src/main/java/com/onesignal/inAppMessages/internal/triggers/impl/TriggerController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ internal class TriggerController(
}

val operatorType = trigger.operatorType
// If trigger is type of NOT_EQUAL_TO, true if only there exists a trigger with the same key and different value.
// In that case, do not return early so it will evaluate later.
val deviceValue =
triggers[trigger.property]
?: // If we don't have a local value for this trigger, can only be true in two cases;
// 1. If operator is Not Exists
// 2. Checking to make sure the key doesn't equal a specific value, other than null of course.
return if (operatorType == Trigger.OSTriggerOperator.NOT_EXISTS) true else operatorType == Trigger.OSTriggerOperator.NOT_EQUAL_TO && trigger.value != null
?: // If we don't have a local value for this trigger, can only be true if operator is Not Exists
return operatorType == Trigger.OSTriggerOperator.NOT_EXISTS

// We have local value at this point, we can evaluate existence checks
if (operatorType == Trigger.OSTriggerOperator.EXISTS) {
Expand Down
Loading
Loading