Skip to content

Conversation

@hakonhagland
Copy link
Collaborator

@hakonhagland hakonhagland commented Aug 22, 2025

See OPM/opm-simulators#6075 and OPM/opm-simulators#6418 and OPM/opm-common#4690 for background. We need to add support for a new type of docstrings_simulators.json with template parameter support. This is to avoid documentation duplication between different simulators as described in the referenced PRs.

- Detect template format (with 'simulators' and 'common_methods' keys)
- Expand templates for all defined simulators
- Generate documentation for both BlackOil and GasWater simulators
- Maintain backward compatibility for flat JSON format
- Process escaped newlines in docstrings correctly
Copy link
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@akva2 akva2 merged commit 5b5b263 into OPM:master Sep 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants