Upgrade requests 2.32.3->2.32.4 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritorto
changed the title
python/sphinx_docs/pyproject.toml
Outdated
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.10" | ||
| requests = ">=2.32.4" |
Collaborator
There was a problem hiding this comment.
Maybe we should use the caret operator instead of ">=" operator? To be consistent with the other package requirements which use the caret operator
Member
Author
There was a problem hiding this comment.
Good point, I'll change that. Thanks!
aritorto
force-pushed
the
upgradeRequests
branch
from
6276475 to
781d641
Compare
aritorto
force-pushed
the
upgradeRequests
branch
from
781d641 to
48f0b52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub dependabot warns about a security vulnerability (.netrc credentials may be exposed to third parties through crafted URLs.) in the current version of requests 2.32.3 (see poetry.lock file) and recommends upgrading it to version 2.32.4 or later, see https://github.com/OPM/opm-python-documentation/security/dependabot/7
While attempting to update requests from version 2.32.3 to 2.32.4 using poetry install, the version was unexpectedly downgraded to 2.32.2.
To resolve this, the dependency was explicitly pinned by adding requests = ">=2.32.4" under the [tool.poetry.dependencies] section in pyproject.toml, followed by running poetry update requests to apply the change correctly.