mdspan to DLPack
#7027
Open
mdspan to DLPack
#7027
+1,506
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
davebayer
requested changes
Dec 19, 2025
Co-authored-by: David Bayer <48736217+davebayer@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
I was also wondering whether we don't want to introduce a special namespace (something like |
davebayer
reviewed
Dec 19, 2025
davebayer
reviewed
Dec 19, 2025
This comment has been minimized.
This comment has been minimized.
Contributor
😬 CI Workflow Results🟥 Finished in 1h 10m: Pass: 82%/91 | Total: 17h 13m | Max: 1h 10m | Hits: 97%/213965See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR implements conversion utilities that take a (host/device/managed)
mdspanand produce a DLTensor view of the same underlying memory.The main issue is how to handle the memory associated with the
shapeandstridearray of DLPack.The implementation provides a small wrapper that owns the shape and strides arrays and stores a DLTensor whose shape/strides pointers refer into those arrays.
Todo: