Skip to content

Add a way to detect the newly introduced (1.21.9) pack version format #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noeppi-noeppi merged 1 commit into from
Sep 30, 2025
Merged

Add a way to detect the newly introduced (1.21.9) pack version format #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/org/moddingx/modgradle/util/ModGradleVersionAccess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,12 @@ private synchronized PackVersions packVersions(String minecraft) {
if (path.equals("version.json")) {
Reader reader = new InputStreamReader(zin, StandardCharsets.UTF_8);
JsonObject json = GSON.fromJson(reader, JsonObject.class);
if (json.has("pack_version") && json.get("pack_version").isJsonObject() && json.get("pack_version") instanceof JsonObject packVersionObj && packVersionObj.has("resource")) {
packVersions = new PackVersions(packVersionObj.get("resource").getAsInt(), packVersionObj.has("data") ? Optional.of(packVersionObj.get("data").getAsInt()) : Optional.empty());
if (json.has("pack_version") && json.get("pack_version").isJsonObject() && json.get("pack_version") instanceof JsonObject packVersionObj) {
if (packVersionObj.has("resource")) {
packVersions = new PackVersions(packVersionObj.get("resource").getAsInt(), packVersionObj.has("data") ? Optional.of(packVersionObj.get("data").getAsInt()) : Optional.empty());
} else if (packVersionObj.has("resource_major")) {
packVersions = new PackVersions(packVersionObj.get("resource_major").getAsInt(), packVersionObj.has("data_major") ? Optional.of(packVersionObj.get("data_major").getAsInt()) : Optional.empty());
}
}
}
}
Expand Down