Skip to content

(AB#330346) Add doc for output accessibility #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

(AB#330346) Add doc for output accessibility #270

merged 2 commits into from
Oct 29, 2024

Conversation

@michaeltlombardi
Copy link
Contributor

@michaeltlombardi michaeltlombardi commented Oct 23, 2024

PR Summary

Adds an edited draft of the output accessibility document for DSC v3.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
sdwheeler
sdwheeler requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes

theJasonHelmick
theJasonHelmick approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@theJasonHelmick theJasonHelmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Sean's changes - LGTM

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Oct 23, 2024

Learn Build status updates of commit 36dc3e1:

✅ Validation status: passed

File Status Preview URL Details
dsc/docs-conceptual/dsc-3.0/concepts/output-accessibility.md ✅Succeeded View (dsc-3.0)
dsc/docs-conceptual/dsc-3.0/toc.yml ✅Succeeded View (dsc-3.0)

For more details, please refer to the build report.

For any questions, please:

mgreenegit
mgreenegit approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@mgreenegit mgreenegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. :shipit:

@sdwheeler sdwheeler merged commit 8bcb6cb into MicrosoftDocs:main Oct 29, 2024
3 checks passed
sdwheeler added a commit that referenced this pull request Oct 29, 2024
@sdwheeler @michaeltlombardi
(AB#330346) Add doc for output accessibility (#270) (#271)
1235a1e 
* (AB#330346) Add doc for output accessibility

* Apply suggestions from code review

---------

Co-authored-by: Mikey Lombardi (He/Him) <mlombardi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdwheeler sdwheeler sdwheeler approved these changes

+2 more reviewers

@mgreenegit mgreenegit mgreenegit approved these changes

@theJasonHelmick theJasonHelmick theJasonHelmick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaeltlombardi @mgreenegit @theJasonHelmick @sdwheeler