-
Notifications
You must be signed in to change notification settings - Fork 2
Cooling tower first model #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 29 commits
fecbf88
09c362f
8f0cb64
f3d9107
2cf625c
dec12b1
8db44a3
1f5ac4a
8289c87
b396da0
b9a9f12
b2b137f
f7abffa
c047767
78a0e7b
05bf4a6
3e1bd9d
f150e11
59c7886
16790e5
ada350a
716c2f2
64e7e62
87697c5
5d870a1
e251278
9bf1165
b8f1889
54c1b01
b6e7cc4
0c1907c
852091b
7b377c0
7aee51c
b64a2b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,220 @@ | ||||||
| within MetroscopeModelingLibrary.MultiFluid.HeatExchangers; | ||||||
| model CoolingTowerMerkel | ||||||
| MetroscopeModelingLibrary.MoistAir.Connectors.Inlet C_cold_in annotation (Placement(transformation(extent={{-10,80},{10,100}}))); | ||||||
| package Water = MetroscopeModelingLibrary.Utilities.Media.WaterSteamMedium; | ||||||
| package MoistAir = MetroscopeModelingLibrary.Utilities.Media.MoistAirMedium; | ||||||
| import MetroscopeModelingLibrary.Utilities.Units; | ||||||
| import MetroscopeModelingLibrary.Utilities.Units.Inputs; | ||||||
| import MetroscopeModelingLibrary.Utilities.Media.WaterSteamMedium; | ||||||
| import MetroscopeModelingLibrary.Utilities.Media.MoistAirMedium.specificEnthalpy; | ||||||
|
|
||||||
| Units.Velocity V_inlet; //Wind velocity entering cooling tower | ||||||
|
||||||
| Units.Velocity V_inlet; //Wind velocity entering cooling tower | |
| Units.Velocity V_inlet; //Air velocity at the bottom of the cooling tower |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is if the filling or the packing ?
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is not very clear: the ratio of what ?
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the naming og the effiency to be consistent with the library
| Inputs.InputReal efan; //Fan effiency | |
| Inputs.InputReal eta_fan; //Fan effiency |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| parameter String configuration = "natural draft"; | |
| parameter String configuration = "natural"; |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give a description for W. It's an important variable, its declaration should be done in the first lines of the model
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Energy Balance - Supplementary Equation | |
| // Energy Balance |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on of the main hypothesis of this model, it should be more highlighted with a comment
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if configuration == "natural draft" then | |
| if configuration == "natural" then |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| else | |
| elseif configuration == "mechanical" then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a description of your model with the reference of the article