Skip to content

Cooling tower first model #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
phelimb-met wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Cooling tower first model #472

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
fecbf88
Cooling tower first model
phelimb-met Mar 27, 2024
09c362f
Correct air pressure
hadrienp-met Mar 27, 2024
8f0cb64
Update
hadrienp-met Mar 28, 2024
f3d9107
sink/source
phelimb-met Apr 2, 2024
2cf625c
sink/source
phelimb-met Apr 2, 2024
dec12b1
balanced the component equations and got direct simulation to run
phelimb-met Apr 3, 2024
8db44a3
Causality correction
hadrienp-met Apr 3, 2024
1f5ac4a
Correct component
hadrienp-met Apr 3, 2024
8289c87
balanced the component equations and got direct simulation to run
phelimb-met Apr 3, 2024
b396da0
Update
phelimb-met Apr 5, 2024
b9a9f12
Update
phelimb-met Apr 5, 2024
b2b137f
Update
phelimb-met Apr 5, 2024
f7abffa
Update BCs values
hadrienp-met Apr 9, 2024
c047767
poppe model
phelimb-met Apr 18, 2024
78a0e7b
Poppe Model Update
phelimb-met Apr 22, 2024
05bf4a6
Update CT Poppe model
hadrienp-met Apr 23, 2024
3e1bd9d
Poppe Model Problem
phelimb-met Apr 30, 2024
f150e11
Parameter definition outside the component
hadrienp-met Apr 30, 2024
59c7886
Forgot a comment
hadrienp-met Apr 30, 2024
16790e5
Latest Poppe Model
phelimb-met May 2, 2024
ada350a
Test function
hadrienp-met May 3, 2024
716c2f2
Pop Model
phelimb-met May 13, 2024
64e7e62
Poppe model update
hadrienp-met May 16, 2024
87697c5
Poppe model update
hadrienp-met May 16, 2024
5d870a1
Poppe Model with SS
phelimb-met May 21, 2024
e251278
Update
phelimb-met May 27, 2024
9bf1165
merge
phelimb-met May 27, 2024
b8f1889
3/6
phelimb-met Jun 3, 2024
54c1b01
Forced Draft Cooling Tower
phelimb-met Jun 17, 2024
b6e7cc4
Github Comments Implemented
phelimb-met Jun 26, 2024
0c1907c
Q_evap correction - Poppe
phelimb-met Jun 26, 2024
852091b
N_step = 20
phelimb-met Jul 1, 2024
7b377c0
15/7
phelimb-met Jul 15, 2024
7aee51c
Final Push
phelimb-met Aug 19, 2024
b64a2b0
yes
phelimb-met Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTower3.mo
View file
Open in desktop
Copy link
Contributor

@hadrienp-met hadrienp-met Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now the heat exchange is between the water source and water sink, so the component hot_side_cooling should be replace by an IsoPHFlowModel (at the moment it is an IsoPFlowModel )

Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ model CoolingTower3
equation
// Definition
Q_cold = Air_inlet.Q_in;
Q_hot = Water_outlet.Q_out;
Q_hot = Water_inlet.Q_in;

T_hot_in = hot_side_cooling.T_in;
T_hot_out = hot_side_cooling.T_out;
T_hot_in = Water_inlet.T_in; //hot_side_cooling
T_hot_out = Water_outlet.T_out;
P_in = Air_inlet.P_in;
P_out = Air_outlet.P_out;
T_cold_in = Air_inlet.T_in;
Expand All @@ -130,8 +130,8 @@ equation
Air_outlet.Q_out * (1 - Air_outlet.Xi_out[1]) = - Air_inlet.Q_in *(1 - Air_inlet.Xi_in[1]);

Water_outlet.P_out = Water_inlet.P_in;
Water_outlet.T_out = Water_inlet.T_in;
Water_outlet.Q_out = Water_inlet.Q_in - Q_makeup;
//Water_outlet.T_out = Water_inlet.T_in;
Water_outlet.Q_out = Q_hot - Q_makeup;
Copy link
Contributor

@hadrienp-met hadrienp-met Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q_out it negative (flow going out a componenet is negative by convention, so here it should be :
Water_outlet.Q_out = - (Q_hot - Q_makeup);

Copy link
Contributor

@hadrienp-met hadrienp-met Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be a could idea to create a new variable Q_hot_out and renaming Q_hot by Q_hot_in


i1 = MoistAir.h_pTX(P_in, T1, {MoistAir.massFraction_pTphi(P_in, T1, 1)}) - ((i_initial + 0.1 * (i_final - i_initial))); //First integral section
i2 = MoistAir.h_pTX(P_in, T2, {MoistAir.massFraction_pTphi(P_in, T2, 1)}) - ((i_initial + 0.4 * (i_final - i_initial)));
Expand Down
12 changes: 6 additions & 6 deletions MetroscopeModelingLibrary/Tests/Multifluid/HeatExchangers/CoolingTower_direct.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ model CoolingTower_direct

// Boundary Conditions
// Hot Water Inlet
input Real waterInletTemp(start=45) "deg_C";
input Real waterInletTemp(start=35) "deg_C";
input Units.VolumeFlowRate waterFlow(start=39) "m3/s";
input Real waterInletPress(start=1) "bar";

Expand All @@ -14,10 +14,10 @@ model CoolingTower_direct
input Units.Fraction cold_source_relative_humidity(start=0.8) "1";

// Observables for calibration
output Real WaterOutletTemp(start=37.75459) "deg_C";
output Real WaterOutletTemp(start=24.999994) "deg_C";

// Calibrated Parameters
parameter Real hd = 0.009132665;
parameter Real hd = -0.037266716;
parameter Real Kfr = 0;

// Parameters
Expand All @@ -27,12 +27,12 @@ model CoolingTower_direct
output Real V_inlet(start = 4.3490353) "m/s"; //output

// Observables
output Real airFlow(start=15214.605) "kg/s";
output Real airFlow(start=12894.166) "kg/s";
output Real Q_makeup(start=379.48428); /// check these
output Real Q_cold(start=15214.605);

output Real AirOutletTemp(start=45.27341) "deg_C"; //output
output Real airOutletPress(start=0.99);
input Real AirOutletTemp(start=35) "deg_C"; //output
output Real airOutletPress(start=1);

// Output
output Units.Fraction cold_sink_relative_humidity(start=1) "1";
Expand Down
6 changes: 3 additions & 3 deletions MetroscopeModelingLibrary/Tests/Multifluid/HeatExchangers/CoolingTower_reverse.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ model CoolingTower_reverse

// Boundary Conditions
// Hot Water Inlet
input Real waterInletTemp(start=45) "deg_C";
input Real waterInletTemp(start=35) "deg_C";
input Units.VolumeFlowRate waterFlow(start=39) "m3/s";
input Real waterInletPress(start=1) "bar";

Expand Down Expand Up @@ -32,7 +32,7 @@ model CoolingTower_reverse
output Real Q_cold(start=52552.133) "m3/s";

output Real airOutletPress(start=1) "bar";
output Real AirOutletTemp(start=35) "deg_C";
input Real AirOutletTemp(start=35) "deg_C"; //output
Copy link
Contributor

@hadrienp-met hadrienp-met Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the correction on the component (isoPH instead of isoP), you won't have anymore to impose this temperature


// Output
output Units.Fraction cold_sink_relative_humidity(start=1) "1";
Expand Down Expand Up @@ -107,7 +107,7 @@ equation

// Observable for Calibration
WaterOutletTemp_sensor.T_degC = WaterOutletTemp;
AirOutletTemp_sensor.T_degC = AirOutletTemp;
AirOutletTemp_sensor.T_degC = AirOutletTemp-10*time;
Copy link
Contributor

@hadrienp-met hadrienp-met Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful to not forget *time in your model, it should be used only for testing


connect(CoolingTower.C_hot_in, waterInletPress_sensor.C_out) annotation (Line(points={{-1.5,-18},{-14,-18},{-14,-20},{-16,-20}},
color={28,108,200}));
Expand Down