Skip to content

Conversation

@pierre-eliep-met
Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met commented Sep 23, 2022

Goal

Fixes #288 by removing the adiabatic compression (no retrocompatibity issue as this parameter was not used, and not present in the _withStartValues model)
Also fixes #302 by giving physically sound values for the unit test.

Type of change

  • Bugfix (non-breaking change which fixes a bug/issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which reorganizes code)
  • Release & Version Update (when cumulative changes justify a release)
  • Documentation Update

Checklist

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

GitHub checks:

  • I have added the appropriate tags, reviewers, projects and linked issues to this PR
  • I have checked for conflicts with target branch, and merged/rebased in consequence

Model development checks:

  • I have performed a self-review of my own code
  • I have checked that my changes do not bring any retrocompatibility issue comparing to MML3-DTG-v3 version
  • Existing tests pass (including Metroscopia !).
  • I have added/updated tests that prove my development works and does not break anything.

Library checks:

  • I have checked in the file explorer that I am not adding duplicate file/folder/package (due to renaming or moving file/package)
  • I have checked that the packages I upload are stored as separate files

Documentation checks:

  • I have made corresponding changes or additions to the documentation
  • I have added corresponding entries to the Changelog

Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
@pierre-eliep-met pierre-eliep-met added ♻️refactoring A code change that neither fixes a bug nor adds a feature 🧪testing Adding missing tests or correcting existing tests labels Sep 23, 2022
@pierre-eliep-met pierre-eliep-met added this to the MML3 Publication milestone Sep 23, 2022
@pierre-eliep-met pierre-eliep-met self-assigned this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️refactoring A code change that neither fixes a bug nor adds a feature 🧪testing Adding missing tests or correcting existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MetroscopeModelingLibrary.Tests.WaterSteam.Machines.Pump_reverse has no solution [Refacto]: Remove pump's adiabatic compression

3 participants