Skip to content

set min-max flow rate to 0 in units #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022
Merged

set min-max flow rate to 0 in units #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b09331
set min-max flow rate to 0 in units
pierre-eliep-met Sep 23, 2022
ac5d9e0
Update CHANGELOG.md
pierre-eliep-met Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### Fixed <!--Make sure to add a link to the PR and issues related to your change-->
- Fixed [#282](https://github.com/Metroscope-dev/metroscope-modeling-library/issues/282) with [#287](https://github.com/Metroscope-dev/metroscope-modeling-library/issues/287), by setting min and max in Positive/Negative MassFlowRate to 0, as it was an unnecessary protection.
- Fixed [#273](https://github.com/Metroscope-dev/metroscope-modeling-library/issues/273), steam extraction splitter'`x` are lower than 1 [PR#275](https://github.com/Metroscope-dev/metroscope-modeling-library/pull/275)
- Fixed `IsoHFlowModel` and `IsoPHFlowModel` now use `h_0` as `h` start value with [PR #265]([url](https://github.com/Metroscope-dev/metroscope-modeling-library/pull/265))
- Fixed `NTU HX` test configuration name for `shell_and_tubes` test, [PR #239](https://github.com/Metroscope-dev/metroscope-modeling-library/pull/239)
Expand Down
2 changes: 1 addition & 1 deletion MetroscopeModelingLibrary/Units/NegativeMassFlowRate.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
within MetroscopeModelingLibrary.Units;
type NegativeMassFlowRate=SI.MassFlowRate(max=-1e-5, start=-1e3, nominal=-1e3);
type NegativeMassFlowRate=SI.MassFlowRate(max=0, start=-1e3, nominal=-1e3);
3 changes: 1 addition & 2 deletions MetroscopeModelingLibrary/Units/PositiveMassFlowRate.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
within MetroscopeModelingLibrary.Units;
type PositiveMassFlowRate =
SI.MassFlowRate(min=1e-5, start=1e3, nominal=1e3);
type PositiveMassFlowRate = SI.MassFlowRate(min=0, start=1e3, nominal=1e3);